Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 469093002: Include <limits.h> in util/file/file_writer.cc because it uses IOV_MAX (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Include <limits.h> in util/file/file_writer.cc because it uses IOV_MAX. This also updates mini_chromium to abd6e3792f4f. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/01f9e396b844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M util/file/file_writer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-13 22:54:26 UTC) #1
Robert Sesek
lgtm
6 years, 4 months ago (2014-08-14 16:03:02 UTC) #2
Mark Mentovai
6 years, 4 months ago (2014-08-14 16:58:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 01f9e396b844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698