Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: util/file/file_writer.cc

Issue 469093002: Include <limits.h> in util/file/file_writer.cc because it uses IOV_MAX (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/file/file_writer.h" 15 #include "util/file/file_writer.h"
16 16
17 #include <algorithm> 17 #include <algorithm>
18 18
19 #include <limits.h>
20
19 #include "base/logging.h" 21 #include "base/logging.h"
20 #include "base/posix/eintr_wrapper.h" 22 #include "base/posix/eintr_wrapper.h"
21 #include "util/file/fd_io.h" 23 #include "util/file/fd_io.h"
22 24
23 namespace crashpad { 25 namespace crashpad {
24 26
25 // Ensure type compatibility between WritableIoVec and iovec. 27 // Ensure type compatibility between WritableIoVec and iovec.
26 COMPILE_ASSERT(sizeof(WritableIoVec) == sizeof(iovec), WritableIoVec_size); 28 COMPILE_ASSERT(sizeof(WritableIoVec) == sizeof(iovec), WritableIoVec_size);
27 COMPILE_ASSERT(offsetof(WritableIoVec, iov_base) == offsetof(iovec, iov_base), 29 COMPILE_ASSERT(offsetof(WritableIoVec, iov_base) == offsetof(iovec, iov_base),
28 WritableIoVec_base_offset); 30 WritableIoVec_base_offset);
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 142
141 off_t rv = lseek(fd_.get(), offset, whence); 143 off_t rv = lseek(fd_.get(), offset, whence);
142 if (rv < 0) { 144 if (rv < 0) {
143 PLOG(ERROR) << "lseek"; 145 PLOG(ERROR) << "lseek";
144 } 146 }
145 147
146 return rv; 148 return rv;
147 } 149 }
148 150
149 } // namespace crashpad 151 } // namespace crashpad
OLDNEW
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698