Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: Source/modules/geofencing/Geofencing.cpp

Issue 468913007: Add support for CallbackPromiseAdapter<void, T> matching WebCallbacks<void, T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@geofencing5
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/geofencing/Geofencing.h" 6 #include "modules/geofencing/Geofencing.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "bindings/core/v8/ScriptPromiseResolver.h" 10 #include "bindings/core/v8/ScriptPromiseResolver.h"
11 #include "core/dom/DOMException.h" 11 #include "core/dom/DOMException.h"
12 #include "core/dom/ExceptionCode.h" 12 #include "core/dom/ExceptionCode.h"
13 #include "modules/geofencing/GeofencingError.h" 13 #include "modules/geofencing/GeofencingError.h"
14 #include "modules/geofencing/GeofencingRegion.h" 14 #include "modules/geofencing/GeofencingRegion.h"
15 #include "public/platform/Platform.h" 15 #include "public/platform/Platform.h"
16 #include "public/platform/WebGeofencingProvider.h" 16 #include "public/platform/WebGeofencingProvider.h"
17 17
18 namespace blink { 18 namespace blink {
19 19
20 namespace { 20 namespace {
21 21
22 // Copy of same class in ServiceWorkerContainer.cpp
23 class UndefinedValue {
24 public:
25 typedef blink::WebGeofencingError WebType;
26 static V8UndefinedType take(ScriptPromiseResolver* resolver, WebType* value)
27 {
28 ASSERT(!value); // Anything passed here will be leaked.
29 return V8UndefinedType();
30 }
31
32 static void dispose(WebType* value)
33 {
34 ASSERT(!value); // Anything passed here will be leaked.
35 }
36
37 private:
38 UndefinedValue();
39 };
40
41 class RegionArray { 22 class RegionArray {
42 public: 23 public:
43 typedef blink::WebVector<blink::WebGeofencingRegion> WebType; 24 typedef blink::WebVector<blink::WebGeofencingRegion> WebType;
44 static HeapVector<Member<GeofencingRegion> > take(ScriptPromiseResolver* res olver, WebType* regionsRaw) 25 static HeapVector<Member<GeofencingRegion> > take(ScriptPromiseResolver* res olver, WebType* regionsRaw)
45 { 26 {
46 OwnPtr<WebType> webRegions = adoptPtr(regionsRaw); 27 OwnPtr<WebType> webRegions = adoptPtr(regionsRaw);
47 HeapVector<Member<GeofencingRegion> > regions; 28 HeapVector<Member<GeofencingRegion> > regions;
48 for (size_t i = 0; i < webRegions->size(); ++i) { 29 for (size_t i = 0; i < webRegions->size(); ++i) {
49 regions.append(GeofencingRegion::createFromWebRegion((*webRegions)[i ])); 30 regions.append(GeofencingRegion::createFromWebRegion((*webRegions)[i ]));
50 } 31 }
(...skipping 18 matching lines...) Expand all
69 50
70 ScriptPromise Geofencing::registerRegion(ScriptState* scriptState, GeofencingReg ion* region) 51 ScriptPromise Geofencing::registerRegion(ScriptState* scriptState, GeofencingReg ion* region)
71 { 52 {
72 WebGeofencingProvider* provider = Platform::current()->geofencingProvider(); 53 WebGeofencingProvider* provider = Platform::current()->geofencingProvider();
73 if (!provider) 54 if (!provider)
74 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError)); 55 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError));
75 56
76 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState); 57 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState);
77 ScriptPromise promise = resolver->promise(); 58 ScriptPromise promise = resolver->promise();
78 // TODO(mek): somehow pass a reference to the current serviceworker to the p rovider. 59 // TODO(mek): somehow pass a reference to the current serviceworker to the p rovider.
79 provider->registerRegion(region->webRegion(), new CallbackPromiseAdapter<Und efinedValue, GeofencingError>(resolver)); 60 provider->registerRegion(region->webRegion(), new CallbackPromiseAdapter<voi d, GeofencingError>(resolver));
80 return promise; 61 return promise;
81 } 62 }
82 63
83 ScriptPromise Geofencing::unregisterRegion(ScriptState* scriptState, const Strin g& regionId) 64 ScriptPromise Geofencing::unregisterRegion(ScriptState* scriptState, const Strin g& regionId)
84 { 65 {
85 WebGeofencingProvider* provider = Platform::current()->geofencingProvider(); 66 WebGeofencingProvider* provider = Platform::current()->geofencingProvider();
86 if (!provider) 67 if (!provider)
87 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError)); 68 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError));
88 69
89 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState); 70 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState);
90 ScriptPromise promise = resolver->promise(); 71 ScriptPromise promise = resolver->promise();
91 // TODO(mek): somehow pass a reference to the current serviceworker to the p rovider. 72 // TODO(mek): somehow pass a reference to the current serviceworker to the p rovider.
92 provider->unregisterRegion(regionId, new CallbackPromiseAdapter<UndefinedVal ue, GeofencingError>(resolver)); 73 provider->unregisterRegion(regionId, new CallbackPromiseAdapter<void, Geofen cingError>(resolver));
93 return promise; 74 return promise;
94 } 75 }
95 76
96 ScriptPromise Geofencing::getRegisteredRegions(ScriptState* scriptState) const 77 ScriptPromise Geofencing::getRegisteredRegions(ScriptState* scriptState) const
97 { 78 {
98 WebGeofencingProvider* provider = Platform::current()->geofencingProvider(); 79 WebGeofencingProvider* provider = Platform::current()->geofencingProvider();
99 if (!provider) 80 if (!provider)
100 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError)); 81 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError));
101 82
102 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState); 83 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState);
103 ScriptPromise promise = resolver->promise(); 84 ScriptPromise promise = resolver->promise();
104 // TODO(mek): somehow pass a reference to the current serviceworker to the p rovider. 85 // TODO(mek): somehow pass a reference to the current serviceworker to the p rovider.
haraken 2014/08/20 00:43:27 Nit: Use a FIXME instead of TODO(mek) in Blink.
105 provider->getRegisteredRegions(new CallbackPromiseAdapter<RegionArray, Geofe ncingError>(resolver)); 86 provider->getRegisteredRegions(new CallbackPromiseAdapter<RegionArray, Geofe ncingError>(resolver));
106 return promise; 87 return promise;
107 } 88 }
108 89
109 } // namespace blink 90 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698