Add support for CallbackPromiseAdapter<void, T> matching WebCallbacks<void, T>.

Add support for CallbackPromiseAdapter<void, T> matching WebCallbacks<void, T>.

This makes it possible to eliminate the various UndefinedValue classes that are sprinkled throughout the Service Worker code.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180703

[Marijn Kruisselbrink, 2014-08-19 20:44:58]

With some more template trickery and an extra class or two I could probably
eliminate most of the code duplication between the two CallbackPromiseAdapter
classes, but I'm not sure if the added complexity is worth it, since the class
is pretty simple.

Currently included in this CL are the changes to geofencing code to use
CallbackPromiseAdapter<void>, but it would probably make more sense to land this
CL before the CL that adds the geofencing code
(https://codereview.chromium.org/464073002/), in which case the geofencing
changes of course wouldn't be part of this CL.

Separately the redundant UndefinedValue classes and related code in
ServiceWorkerContainer, ServiceWorkerRegistration etc should then also be
cleaned up, but that will be slightly more complicated since it would also
require content side changes, since the type of the callbacks would change.

[haraken, 2014-08-20 00:43:27]

Looks good but hirano-san might want to take another look at this.

https://codereview.chromium.org/468913007/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/CallbackPromiseAdapter.h (right):

https://codereview.chromium.org/468913007/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/CallbackPromiseAdapter.h:114:
CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)

Add explicit.

https://codereview.chromium.org/468913007/diff/20001/Source/modules/geofencin...
File Source/modules/geofencing/Geofencing.cpp (right):

https://codereview.chromium.org/468913007/diff/20001/Source/modules/geofencin...
Source/modules/geofencing/Geofencing.cpp:85: // TODO(mek): somehow pass a
reference to the current serviceworker to the provider.

Nit: Use a FIXME instead of TODO(mek) in Blink.

[yhirano, 2014-08-20 06:07:48]

lgtm

[haraken, 2014-08-20 06:13:42]

LGTM2

[Marijn Kruisselbrink, 2014-08-20 20:45:53]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:46:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mek@chromium.org/468913007/40001

[commit-bot: I haz the power, 2014-08-20 21:26:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20610)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-08-20 21:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 21:29:14]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[Marijn Kruisselbrink, 2014-08-21 04:54:41]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-08-21 04:55:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mek@chromium.org/468913007/40001

[commit-bot: I haz the power, 2014-08-21 07:21:04]

Committed patchset #3 (40001) as 180703