Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 468903002: No need to re-parse empty set of injected stylesheets. (Closed)

Created:
6 years, 4 months ago by rune
Modified:
6 years, 3 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

No need to re-parse empty set of injected stylesheets. setCompatibilityMode invalidates the injected stylesheet cache which means styleResolverChanged() and an updating of the active stylesheets list. The reason is that the injected stylesheets need to be re-parsed with the correct strict/quirks mode. If the list of injected stylesheets is empty, there are no stylesheets to reparse, so avoid styleResolverChanged(). This might not mean much in practice, depending on where the compat mode may change, but the styleResolverChanged was noise while trying to analyze the bug in question. BUG=393480 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181125

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (1 generated)
rune
6 years, 4 months ago (2014-08-14 09:10:14 UTC) #1
rune
PTAL
6 years, 4 months ago (2014-08-19 09:39:13 UTC) #2
esprehn
https://codereview.chromium.org/468903002/diff/1/Source/core/dom/StyleEngine.cpp File Source/core/dom/StyleEngine.cpp (right): https://codereview.chromium.org/468903002/diff/1/Source/core/dom/StyleEngine.cpp#newcode236 Source/core/dom/StyleEngine.cpp:236: if (!m_injectedAuthorStyleSheets.isEmpty()) Is this correct? If the cache is ...
6 years, 4 months ago (2014-08-19 11:30:59 UTC) #3
rune
https://codereview.chromium.org/468903002/diff/1/Source/core/dom/StyleEngine.cpp File Source/core/dom/StyleEngine.cpp (right): https://codereview.chromium.org/468903002/diff/1/Source/core/dom/StyleEngine.cpp#newcode236 Source/core/dom/StyleEngine.cpp:236: if (!m_injectedAuthorStyleSheets.isEmpty()) On 2014/08/19 11:30:59, esprehn wrote: > Is ...
6 years, 4 months ago (2014-08-19 13:31:16 UTC) #4
rune
ping
6 years, 3 months ago (2014-08-29 09:02:22 UTC) #5
esprehn
lgtm
6 years, 3 months ago (2014-08-29 20:09:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-08-30 00:44:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181125

Powered by Google App Engine
This is Rietveld 408576698