Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Side by Side Diff: Source/core/dom/StyleEngine.cpp

Issue 468903002: No need to re-parse empty set of injected stylesheets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/StyleEngine.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 224
225 void StyleEngine::invalidateInjectedStyleSheetCache() 225 void StyleEngine::invalidateInjectedStyleSheetCache()
226 { 226 {
227 m_injectedStyleSheetCacheValid = false; 227 m_injectedStyleSheetCacheValid = false;
228 markDocumentDirty(); 228 markDocumentDirty();
229 // FIXME: updateInjectedStyleSheetCache is called inside StyleSheetCollectio n::updateActiveStyleSheets 229 // FIXME: updateInjectedStyleSheetCache is called inside StyleSheetCollectio n::updateActiveStyleSheets
230 // and batch updates lots of sheets so we can't call addedStyleSheet() or re movedStyleSheet(). 230 // and batch updates lots of sheets so we can't call addedStyleSheet() or re movedStyleSheet().
231 document().styleResolverChanged(); 231 document().styleResolverChanged();
232 } 232 }
233 233
234 void StyleEngine::compatibilityModeChanged()
235 {
236 if (!m_injectedAuthorStyleSheets.isEmpty())
esprehn 2014/08/19 11:30:59 Is this correct? If the cache is empty why don't w
rune 2014/08/19 13:31:16 The cache is the set of injected stylesheet which
237 invalidateInjectedStyleSheetCache();
238 }
239
234 void StyleEngine::addAuthorSheet(PassRefPtrWillBeRawPtr<StyleSheetContents> auth orSheet) 240 void StyleEngine::addAuthorSheet(PassRefPtrWillBeRawPtr<StyleSheetContents> auth orSheet)
235 { 241 {
236 m_authorStyleSheets.append(CSSStyleSheet::create(authorSheet, m_document)); 242 m_authorStyleSheets.append(CSSStyleSheet::create(authorSheet, m_document));
237 document().addedStyleSheet(m_authorStyleSheets.last().get()); 243 document().addedStyleSheet(m_authorStyleSheets.last().get());
238 markDocumentDirty(); 244 markDocumentDirty();
239 } 245 }
240 246
241 void StyleEngine::addPendingSheet() 247 void StyleEngine::addPendingSheet()
242 { 248 {
243 m_pendingStylesheets++; 249 m_pendingStylesheets++;
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 visitor->trace(m_resolver); 711 visitor->trace(m_resolver);
706 visitor->trace(m_fontSelector); 712 visitor->trace(m_fontSelector);
707 visitor->trace(m_textToSheetCache); 713 visitor->trace(m_textToSheetCache);
708 visitor->trace(m_sheetToTextCache); 714 visitor->trace(m_sheetToTextCache);
709 visitor->trace(m_xslStyleSheet); 715 visitor->trace(m_xslStyleSheet);
710 #endif 716 #endif
711 CSSFontSelectorClient::trace(visitor); 717 CSSFontSelectorClient::trace(visitor);
712 } 718 }
713 719
714 } 720 }
OLDNEW
« no previous file with comments | « Source/core/dom/StyleEngine.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698