Use a precise target type for Beacon requests.

Use a precise target type for Beacon requests.

To allow the embedder to distinguish POST requests emanating from
sendBeacon() from those from a <a ping>, assign a more precise target
type to the former.

This is done in preparation for adding Beacon-Age: headers to Beacon
requests.

R=mkwst@chromium.org
BUG=398167
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180179

[sof, 2014-08-13 12:50:53]

On 2014/08/13 12:49:14, sof wrote:
> 

Oops, meant to add "Please take a look, if you could." :)

[Mike West, 2014-08-13 13:54:41]

LGTM, thanks for cleaning this up.

https://codereview.chromium.org/468853002/diff/1/Source/core/loader/BeaconLoa...
File Source/core/loader/BeaconLoader.cpp (left):

https://codereview.chromium.org/468853002/diff/1/Source/core/loader/BeaconLoa...
Source/core/loader/BeaconLoader.cpp:25:
request.setRequestContext(blink::WebURLRequest::RequestContextPing);
Why was this note here? It's certainly less relevant now that we've removed the
TargetType enum, but was there a good reason for its being there in the first
place?

[sof, 2014-08-13 14:05:38]

https://codereview.chromium.org/468853002/diff/1/Source/core/loader/BeaconLoa...
File Source/core/loader/BeaconLoader.cpp (left):

https://codereview.chromium.org/468853002/diff/1/Source/core/loader/BeaconLoa...
Source/core/loader/BeaconLoader.cpp:25:
request.setRequestContext(blink::WebURLRequest::RequestContextPing);
On 2014/08/13 13:54:41, Mike West (OOO until 19th) wrote:
> Why was this note here? It's certainly less relevant now that we've removed
the
> TargetType enum, but was there a good reason for its being there in the first
> place?

Just a remark that Blink didn't expose the "Beacon-ness" of the request, as
there was no known need for doing so.

It would have been better if that went hand-in-hand with not defining
RequestContextBeacon, as it wasn't being used. But no longer an issue.

[sof, 2014-08-13 14:06:33]

Thanks for the review.

[sof, 2014-08-13 14:06:37]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-08-13 14:07:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/468853002/1

[commit-bot: I haz the power, 2014-08-13 15:06:07]

Committed patchset #1 (1) as 180179