Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: Source/core/loader/BeaconLoader.cpp

Issue 468853002: Use a precise target type for Beacon requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/BeaconLoader.cpp
diff --git a/Source/core/loader/BeaconLoader.cpp b/Source/core/loader/BeaconLoader.cpp
index 7773528991bc5790ba422e45667ad2c4bcda7bd3..3f4b81a109ed08030f0007c5ae2c94ce717cd136 100644
--- a/Source/core/loader/BeaconLoader.cpp
+++ b/Source/core/loader/BeaconLoader.cpp
@@ -21,8 +21,7 @@ namespace blink {
void BeaconLoader::prepareRequest(LocalFrame* frame, ResourceRequest& request)
{
- // NOTE: do not distinguish Beacon by target type.
- request.setRequestContext(blink::WebURLRequest::RequestContextPing);
Mike West 2014/08/13 13:54:41 Why was this note here? It's certainly less releva
sof 2014/08/13 14:05:38 Just a remark that Blink didn't expose the "Beacon
+ request.setRequestContext(WebURLRequest::RequestContextBeacon);
request.setHTTPMethod("POST");
request.setHTTPHeaderField("Cache-Control", "max-age=0");
request.setAllowStoredCredentials(true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698