Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 468653003: [Findit] Fixed a bug where blame information is not correctly filtered (Closed)

Created:
6 years, 4 months ago by jeun1
Modified:
6 years, 4 months ago
Reviewers:
stgao, jeun
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Findit] Fixed a bug where blame information is not correctly filtered and normalization was not working properly. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290060

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed coderevie #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -33 lines) Patch
M tools/findit/blame.py View 1 3 chunks +2 lines, -3 lines 0 comments Download
M tools/findit/crash_utils.py View 1 8 chunks +14 lines, -28 lines 0 comments Download
M tools/findit/match_set.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/findit/result.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jeun
Hi Shuotao, This is a bugfix on findit algorithm, and it changes only couple lines ...
6 years, 4 months ago (2014-08-15 18:54:13 UTC) #1
stgao
lgtm if comments are addressed. https://codereview.chromium.org/468653003/diff/1/tools/findit/blame.py File tools/findit/blame.py (right): https://codereview.chromium.org/468653003/diff/1/tools/findit/blame.py#newcode156 tools/findit/blame.py:156: int(blame.range_end) < int(blame.revision)): I ...
6 years, 4 months ago (2014-08-15 19:42:38 UTC) #2
jeun
The CQ bit was checked by jeun@google.com
6 years, 4 months ago (2014-08-15 20:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeun@chromium.org/468653003/20001
6 years, 4 months ago (2014-08-15 20:22:12 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 00:05:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290060

Powered by Google App Engine
This is Rietveld 408576698