tools/findit/blame.py - Issue 468653003: [Findit] Fixed a bug where blame information is not correctly filtered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/findit/blame.py

Issue 468653003: [Findit] Fixed a bug where blame information is not correctly filtered (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed coderevie Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/findit/blame.py

diff --git a/tools/findit/blame.py b/tools/findit/blame.py

index 754626232fd5262eae92b355716e0e5ebf45f50f..9d6e98936764715ab7418063fac83b78b17beddd 100644

--- a/tools/findit/blame.py

+++ b/tools/findit/blame.py

@@ -1,4 +1,4 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

@@ -74,7 +74,6 @@ class BlameList(object):

"""

# Only return blame information for first 'top_n_frames' frames.

stack_frames = callstack.GetTopNFrames(top_n_frames)

threads = []

# Iterate through frames in stack.

for stack_frame in stack_frames:

@@ -154,7 +153,7 @@ class BlameList(object):

# Discards results that are after the end of regression.

if not utils.IsGitHash(blame.revision) and (

- int(blame.revision) < int(blame.range_end)):

+ int(blame.range_end) <= int(blame.revision)):

continue

filtered_blame_list.append(blame)

« no previous file with comments | « no previous file | tools/findit/crash_utils.py » ('j') | no next file with comments »