Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2220)

Unified Diff: chrome/common/extensions/api/gcd_private.idl

Issue 468613003: API change to allow sticker authentication for devices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/gcd_private.idl
diff --git a/chrome/common/extensions/api/gcd_private.idl b/chrome/common/extensions/api/gcd_private.idl
index 918a80d95ccb4cd2710ff0cf134af74b55d7aeba..0165ceae78f732b4af96c4ba0a967cc8e92e5e8e 100644
--- a/chrome/common/extensions/api/gcd_private.idl
+++ b/chrome/common/extensions/api/gcd_private.idl
@@ -46,13 +46,16 @@ namespace gcdPrivate {
// Unknown session.
unknownSessionError,
+ // Bad confirmation code. Ask user to retype.
+ badConfirmationCodeError,
+
// Success.
success
};
enum ConfirmationType {
displayCode,
- audio
+ stickerCode
};
callback CloudDeviceListCallback = void(GCDDevice[] devices);
@@ -75,7 +78,8 @@ namespace gcdPrivate {
// Called when the confirmation code is available or on error.
// |sessionId| is the session ID (identifies the session for future calls)
// |status| is the status (success or type of error)
- // |code| is the confirmation code or empty on error
+ // |code| is the confirmation code or empty if not available (code
Vitaly Buka (NO REVIEWS) 2014/08/21 22:15:24 maybe dictionary ConfirmationInfo { Confirmati
Noam Samuel 2014/08/21 23:11:12 Done.
+ // is only available for displayCode confirmation)
// |confirmationType| is the type of confirmation required
callback ConfirmationCodeCallback = void(long sessionId,
Status status,
@@ -124,8 +128,9 @@ namespace gcdPrivate {
long port,
ConfirmationCodeCallback callback);
- // Confirm that the code is correct. Device will still need to confirm.
+ // Send confirmation code. Device will still need to confirm.
static void confirmCode(long sessionId,
Vitaly Buka (NO REVIEWS) 2014/08/21 22:15:24 It's not clear what should be pass here for displa
Noam Samuel 2014/08/21 23:11:12 Done.
+ DOMString code,
SessionEstablishedCallback callback);
// Send an encrypted message to the device. |api| is the API path and
« no previous file with comments | « chrome/browser/local_discovery/privetv3_setup_flow.cc ('k') | chrome/test/data/extensions/api_test/gcd_private/api/session.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698