API change to allow sticker authentication for devices

chrome/common/extensions/api/gcd_private.idl

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.gcdPrivate</code> API to discover GCD APIs and register
 // them.
 namespace gcdPrivate {
 
   enum SetupType { mdns, wifi, cloud };
 
@@ skipping 28 matching lines @@
 
     // Could not connect to the device.
     connectionError,
 
     // Error in establishing session.
     sessionError,
 
     // Unknown session.
     unknownSessionError,
 
+    // Bad confirmation code. Ask user to retype.
+    badConfirmationCodeError,
+
     // Success.
     success
   };
 
   enum ConfirmationType {
     displayCode,
-    audio
+    stickerCode
   };
 
   callback CloudDeviceListCallback = void(GCDDevice[] devices);
 
   // |commandDefinitions| : Is "commandDefs" value of device described at
   // https://developers.google.com/cloud-devices/v1/reference/devices
   // TODO(vitalybuka): consider to describe object in IDL.
   callback CommandDefinitionsCallback = void(object commandDefinitions);
 
   // |command| : Described at
   // https://developers.google.com/cloud-devices/v1/reference/commands
   // TODO(vitalybuka): consider to describe object in IDL.
   callback CommandCallback = void(object command);
 
   // |commands| : Array of commands described at
   // https://developers.google.com/cloud-devices/v1/reference/commands
   // TODO(vitalybuka): consider to describe object in IDL.
   callback CommandListCallback = void(object[] commands);
 
   // Called when the confirmation code is available or on error.
   // |sessionId| is the session ID (identifies the session for future calls)
   // |status| is the status (success or type of error)
-  // |code| is the confirmation code or empty on error
+  // |code| is the confirmation code or empty if not available (code

[Vitaly Buka (NO REVIEWS), 2014/08/21 22:15:24]

maybe 
dictionary ConfirmationInfo {
   ConfirmationType type,
   DOMString? code
}

[Noam Samuel, 2014/08/21 23:11:12]

Done.

+  //    is only available for displayCode confirmation)
   // |confirmationType| is the type of confirmation required
   callback ConfirmationCodeCallback = void(long sessionId,
                                            Status status,
                                            DOMString code,
                                            ConfirmationType type);
 
   // Called to indicated the session is established.
   // |status| is the status (success or type of error)
   callback SessionEstablishedCallback = void(Status status);
 
@@ skipping 28 matching lines @@
     static void prefetchWifiPassword(DOMString ssid, SuccessCallback callback);
 
     // Get the list of ssids with prefetched callbacks.
     static void getPrefetchedWifiNameList(SSIDListCallback callback);
 
     // Establish the session.
     static void establishSession(DOMString ipAddress,
                                  long port,
                                  ConfirmationCodeCallback callback);
 
-    // Confirm that the code is correct. Device will still need to confirm.
+    // Send confirmation code. Device will still need to confirm.
     static void confirmCode(long sessionId,

[Vitaly Buka (NO REVIEWS), 2014/08/21 22:15:24]

It's not clear what should be pass here for displayCode.
maybe use two different functions?

or just make it mandatory to pass code back, please update comment for that

[Noam Samuel, 2014/08/21 23:11:12]

Done.

+                            DOMString code,
                             SessionEstablishedCallback callback);
 
     // Send an encrypted message to the device. |api| is the API path and
     // |input| is the input object. If the message is a setup message with a
     // wifi ssid specified but no password, the password cached from
     // |prefetchWifiPassword| will be used and the call will fail if it's not
     // available. For open networks use an empty string as the password.
     static void sendMessage(long sessionId,
                             DOMString api,
                             object input,
@@ skipping 48 matching lines @@
     // Subscribe to this event to start listening new or updated devices. New
     // listeners will get called with all known devices on the network, and
     // status updates for devices available through the cloud.
     static void onDeviceStateChanged(GCDDevice device);
 
     // Notifies that device has disappeared.
     // |deviceId| : The device has disappeared.
     static void onDeviceRemoved(DOMString deviceId);
   };
 };