API change to allow sticker authentication for devices

API change to allow sticker authentication for devices

Change API to match protocol that may allow sticker authentication
for devices. The PIN will not necessarily be available at provision
time, and the client will need to send a user-typed PIN at
code verification time.

BUG=

Committed: https://crrev.com/18d64ecb4fc72171c55498ee507682085c684e01
Cr-Commit-Position: refs/heads/master@{#291988}

[Vitaly Buka (NO REVIEWS), 2014-08-21 22:15:24]

lgtm

https://codereview.chromium.org/468613003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/468613003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:81: // |code| is the confirmation
code or empty if not available (code
maybe 
dictionary ConfirmationInfo {
   ConfirmationType type,
   DOMString? code
}

https://codereview.chromium.org/468613003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:132: static void confirmCode(long
sessionId,
It's not clear what should be pass here for displayCode.
maybe use two different functions?

or just make it mandatory to pass code back, please update comment for that

[Noam Samuel, 2014-08-21 23:11:12]

+kalman for gcdPrivate.idl

https://codereview.chromium.org/468613003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/468613003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:81: // |code| is the confirmation
code or empty if not available (code
On 2014/08/21 22:15:24, Vitaly Buka wrote:
> maybe 
> dictionary ConfirmationInfo {
>    ConfirmationType type,
>    DOMString? code
> }
> 

Done.

https://codereview.chromium.org/468613003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:132: static void confirmCode(long
sessionId,
On 2014/08/21 22:15:24, Vitaly Buka wrote:
> It's not clear what should be pass here for displayCode.
> maybe use two different functions?
> 
> or just make it mandatory to pass code back, please update comment for that

Done.

[not at google - send to devlin, 2014-08-21 23:17:42]

lgtm

[Noam Samuel, 2014-08-21 23:19:03]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-08-21 23:21:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/468613003/20001

[commit-bot: I haz the power, 2014-08-22 00:15:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 00:26:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 00:26:33]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Noam Samuel, 2014-08-25 22:45:24]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-08-25 22:48:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/468613003/40001

[commit-bot: I haz the power, 2014-08-26 02:19:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 02:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 02:58:26]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Noam Samuel, 2014-08-26 19:10:31]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-08-26 19:12:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/468613003/60001

[commit-bot: I haz the power, 2014-08-26 20:16:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 21:56:03]

Committed patchset #4 (60001) as b27c5bf3eb1746723df0cd0b40d694198bba4b2c

[commit-bot: I haz the power, 2014-09-10 02:45:50]

Patchset 4 (id:??) landed as
https://crrev.com/18d64ecb4fc72171c55498ee507682085c684e01
Cr-Commit-Position: refs/heads/master@{#291988}