Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: remoting/host/host_extension_session.h

Issue 468613002: Readability review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/fake_host_extension.cc ('k') | remoting/host/host_extension_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/host_extension_session.h
diff --git a/remoting/host/host_extension_session.h b/remoting/host/host_extension_session.h
index a4a0bd710abd7c776688028bd9b4ce2bb52d32c3..1c51644c15a452a2273ace98650e1b0c1e4622fe 100644
--- a/remoting/host/host_extension_session.h
+++ b/remoting/host/host_extension_session.h
@@ -27,13 +27,18 @@ class HostExtensionSession {
public:
virtual ~HostExtensionSession() {}
- // Optional hook functions for HostExtensions which need to wrap or replace
- // parts of the video, audio, input, etc pipelines.
- // These are called in response to ResetVideoPipeline().
- virtual scoped_ptr<webrtc::DesktopCapturer> OnCreateVideoCapturer(
- scoped_ptr<webrtc::DesktopCapturer> capturer);
- virtual scoped_ptr<VideoEncoder> OnCreateVideoEncoder(
- scoped_ptr<VideoEncoder> encoder);
+ // Hook functions called when the video pipeline is being (re)constructed.
+ // Implementations will receive these calls only if they express the need to
+ // modify the pipeline (see below). They may replace or wrap |capturer| and/or
+ // |encoder|, e.g. to filter video frames in some way.
+ // If either |capturer| or |encoder| are reset then the video pipeline is not
+ // constructed.
+ virtual void OnCreateVideoCapturer(
+ scoped_ptr<webrtc::DesktopCapturer>* capturer);
+ virtual void OnCreateVideoEncoder(scoped_ptr<VideoEncoder>* encoder);
+
+ // Must return true if the HostExtensionSession needs the opportunity to
+ // modify the video pipeline.
virtual bool ModifiesVideoPipeline() const;
// Called when the host receives an |ExtensionMessage| for the |ClientSession|
« no previous file with comments | « remoting/host/fake_host_extension.cc ('k') | remoting/host/host_extension_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698