remoting/host/host_extension_session.cc - Issue 468613002: Readability review.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/host_extension_session.cc

Issue 468613002: Readability review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/host_extension_session.cc

diff --git a/remoting/host/host_extension_session.cc b/remoting/host/host_extension_session.cc

index 5f548655a38e4bda6b87ac3bc2f9d3387c7386e7..c2d8076bdf5b59e15004478a9ed779bcaad2cf41 100644

--- a/remoting/host/host_extension_session.cc

+++ b/remoting/host/host_extension_session.cc

@@ -9,14 +9,12 @@

namespace remoting {

-scoped_ptr<webrtc::DesktopCapturer> HostExtensionSession::OnCreateVideoCapturer(

- scoped_ptr<webrtc::DesktopCapturer> capturer) {

- return capturer.Pass();

+void HostExtensionSession::OnCreateVideoCapturer(

+ scoped_ptr<webrtc::DesktopCapturer>* capturer) {

}

-scoped_ptr<VideoEncoder> HostExtensionSession::OnCreateVideoEncoder(

- scoped_ptr<VideoEncoder> encoder) {

- return encoder.Pass();

+void HostExtensionSession::OnCreateVideoEncoder(

+ scoped_ptr<VideoEncoder>* encoder) {

}

bool HostExtensionSession::ModifiesVideoPipeline() const {