remoting/host/cast_extension_session.h - Issue 468613002: Readability review.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/cast_extension_session.h

Issue 468613002: Readability review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/cast_extension_session.h

diff --git a/remoting/host/cast_extension_session.h b/remoting/host/cast_extension_session.h

index 03501bf67ae8ac88b46c726f1003d2bded276677..83e477a1e8f76643598c47de3d214c5ab36f2f0e 100644

--- a/remoting/host/cast_extension_session.h

+++ b/remoting/host/cast_extension_session.h

@@ -61,8 +61,8 @@ class CastExtensionSession : public HostExtensionSession,

void OnCreateSessionDescriptionFailure(const std::string& error);

// HostExtensionSession interface.

- virtual scoped_ptr<webrtc::DesktopCapturer> OnCreateVideoCapturer(

- scoped_ptr<webrtc::DesktopCapturer> capturer) OVERRIDE;

+ virtual void OnCreateVideoCapturer(

+ scoped_ptr<webrtc::DesktopCapturer>* capturer) OVERRIDE;

virtual bool ModifiesVideoPipeline() const OVERRIDE;

virtual bool OnExtensionMessage(

ClientSessionControl* client_session_control,

@@ -243,4 +243,3 @@ class CastExtensionSession : public HostExtensionSession,

} // namespace remoting

#endif // REMOTING_HOST_CAST_EXTENSION_SESSION_H_