Chromium Code Reviews| Index: remoting/host/fake_host_extension.h |
| diff --git a/remoting/host/fake_host_extension.h b/remoting/host/fake_host_extension.h |
| index e61828c9a889fe6146b697ac5bab931a4c3a323f..522b86f455982450a7d2ae0d140d51ac7af1996e 100644 |
| --- a/remoting/host/fake_host_extension.h |
| +++ b/remoting/host/fake_host_extension.h |
| @@ -33,26 +33,40 @@ class FakeExtension : public HostExtension { |
| protocol::ClientStub* client_stub) OVERRIDE; |
| // Controls for testing. |
| - void set_steal_video_capturer(bool steal_video_capturer); |
| + void set_steal_video_capturer(bool steal_video_capturer) { |
| + steal_video_capturer_ = steal_video_capturer; |
| + } |
| // Accessors for testing. |
| - bool has_handled_message(); |
| - bool has_wrapped_video_encoder(); |
| - bool has_wrapped_video_capturer(); |
| - bool was_instantiated() { return was_instantiated_; } |
| + bool has_handled_message() const { return has_handled_message_; } |
| + bool has_wrapped_video_encoder() const { return has_wrapped_video_encoder_; } |
| + bool has_wrapped_video_capturer() const { |
| + return has_wrapped_video_capturer_; |
| + } |
| + bool was_instantiated() const { return was_instantiated_; } |
| private: |
| class Session; |
| friend class Session; |
| + // The type name of extension messages that this fake consumes. |
| std::string message_type_; |
| + |
| + // The capability this fake reports, and requires clients to support, if any. |
| std::string capability_; |
| + // True if this extension should intercept creation of the session's video |
| + // capturer and consume it, preventing the video pipeline being created. |
| bool steal_video_capturer_; |
| + // True if a message of |message_type_| has been processed by this extension. |
| bool has_handled_message_; |
| + |
| + // True if this extension had the opportunity to modify the video pipeline. |
| bool has_wrapped_video_encoder_; |
| bool has_wrapped_video_capturer_; |
| + |
| + // True if |CreateExtensionSession| was called on this extension. |
|
Peter Kasting
2014/08/26 20:58:15
Nit: For function names, I think it's more typical
Wez
2014/08/28 00:13:20
Done.
|
| bool was_instantiated_; |
| DISALLOW_COPY_AND_ASSIGN(FakeExtension); |