Issue 468493002: Rewriting SetOwnPropertyIgnoreAttributes using the LookupIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468493002: Rewriting SetOwnPropertyIgnoreAttributes using the LookupIterator (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Rewriting SetOwnPropertyIgnoreAttributes using the LookupIterator BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23163

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -414 lines)			Patch
M	src/lookup.h	View	5 chunks	+14 lines, -19 lines	0 comments	Download
M	src/lookup.cc	View	4 chunks	+37 lines, -4 lines	0 comments	Download
M	src/objects.h	View	7 chunks	+12 lines, -45 lines	0 comments	Download
M	src/objects.cc	View	13 chunks	+118 lines, -340 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

PTAL This requires changing the fast/dom/global-constructors.html layout test. We are already incompatible with firefox; this ...

6 years, 4 months ago (2014-08-12 15:37:00 UTC) #1

Toon Verwaest

6 years, 4 months ago (2014-08-18 14:26:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23163 (tree was closed).