Rewriting SetOwnPropertyIgnoreAttributes using the LookupIterator

src/lookup.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_LOOKUP_H_
 #define V8_LOOKUP_H_
 
 #include "src/factory.h"
 #include "src/isolate.h"
 #include "src/objects.h"
 
 namespace v8 {
 namespace internal {
 
 class LookupIterator V8_FINAL BASE_EMBEDDED {
  public:
   enum Configuration {
-    CHECK_OWN_REAL     = 0,
-    CHECK_HIDDEN       = 1 << 0,
-    CHECK_DERIVED      = 1 << 1,
-    CHECK_INTERCEPTOR  = 1 << 2,
+    CHECK_OWN_REAL = 0,
+    CHECK_HIDDEN = 1 << 0,
+    CHECK_DERIVED = 1 << 1,
+    CHECK_INTERCEPTOR = 1 << 2,
     CHECK_ACCESS_CHECK = 1 << 3,
-    CHECK_ALL          = CHECK_HIDDEN | CHECK_DERIVED |
-                         CHECK_INTERCEPTOR | CHECK_ACCESS_CHECK,
-    SKIP_INTERCEPTOR   = CHECK_ALL ^ CHECK_INTERCEPTOR,
-    CHECK_OWN          = CHECK_ALL ^ CHECK_DERIVED
+    CHECK_HIDDEN_ACCESS = CHECK_HIDDEN | CHECK_ACCESS_CHECK,
+    SKIP_INTERCEPTOR = CHECK_HIDDEN_ACCESS | CHECK_DERIVED,
+    CHECK_ALL = SKIP_INTERCEPTOR | CHECK_INTERCEPTOR,
+    CHECK_OWN = CHECK_HIDDEN_ACCESS | CHECK_INTERCEPTOR
   };
 
   enum State {
     NOT_FOUND,
     PROPERTY,
     INTERCEPTOR,
     ACCESS_CHECK,
     JSPROXY
   };
 
@@ skipping 46 matching lines @@
   Isolate* isolate() const { return isolate_; }
   State state() const { return state_; }
   Handle<Name> name() const { return name_; }
 
   bool IsFound() const { return state_ != NOT_FOUND; }
   void Next();
 
   Heap* heap() const { return isolate_->heap(); }
   Factory* factory() const { return isolate_->factory(); }
   Handle<Object> GetReceiver() const {
-    return Handle<Object>::cast(maybe_receiver_.ToHandleChecked());
+    return maybe_receiver_.ToHandleChecked();
   }
   Handle<Map> holder_map() const { return holder_map_; }
   template <class T>
   Handle<T> GetHolder() const {
     DCHECK(IsFound());
     return Handle<T>::cast(maybe_holder_.ToHandleChecked());
   }
   Handle<JSReceiver> GetRoot() const;
   bool HolderIsReceiverOrHiddenPrototype() const;
-
-  /* Dynamically reduce the trapped types. */
-  void skip_interceptor() {
-    configuration_ = static_cast<Configuration>(
-        configuration_ & ~CHECK_INTERCEPTOR);
-  }
-  void skip_access_check() {
-    configuration_ = static_cast<Configuration>(
-        configuration_ & ~CHECK_ACCESS_CHECK);
-  }
+  bool HolderIsNonGlobalHiddenPrototype() const;
 
   /* ACCESS_CHECK */
   bool HasAccess(v8::AccessType access_type) const;
 
   /* PROPERTY */
   // HasProperty needs to be called before any of the other PROPERTY methods
   // below can be used. It ensures that we are able to provide a definite
   // answer, and loads extra information about the property.
   bool HasProperty();
   void PrepareForDataProperty(Handle<Object> value);
   void TransitionToDataProperty(Handle<Object> value,
                                 PropertyAttributes attributes,
                                 Object::StoreFromKeyed store_mode);
+  void ReconfigureDataProperty(Handle<Object> value,
+                               PropertyAttributes attributes);
   PropertyKind property_kind() const {
     DCHECK(has_property_);
     return property_kind_;
   }
   PropertyEncoding property_encoding() const {
     DCHECK(has_property_);
     return property_encoding_;
   }
   PropertyDetails property_details() const {
     DCHECK(has_property_);
@@ skipping 53 matching lines @@
 
   static Configuration ComputeConfiguration(
       Configuration configuration, Handle<Name> name) {
     if (name->IsOwn()) {
       return static_cast<Configuration>(configuration & CHECK_OWN);
     } else {
       return configuration;
     }
   }
 
+  // If configuration_ becomes mutable, update
+  // HolderIsReceiverOrHiddenPrototype.
   Configuration configuration_;
   State state_;
   bool has_property_;
   PropertyKind property_kind_;
   PropertyEncoding property_encoding_;
   PropertyDetails property_details_;
   Isolate* isolate_;
   Handle<Name> name_;
   Handle<Map> holder_map_;
   MaybeHandle<Object> maybe_receiver_;
   MaybeHandle<JSReceiver> maybe_holder_;
 
   int number_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_LOOKUP_H_