Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 468393003: Add the addIceCandidate failure case to webrtc-internals. (Closed)

Created:
6 years, 4 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add the addIceCandidate failure case to webrtc-internals. Also updates the text for the candidate properties to follow the current spec. BUG=402560 Committed: https://crrev.com/9d972ceb0c410b92dccc5cbf3f8118b0ac6ec3c6 Cr-Commit-Position: refs/heads/master@{#293598}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -25 lines) Patch
M content/renderer/media/peer_connection_tracker.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 2 chunks +17 lines, -6 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 2 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jiayl
PTAL
6 years, 4 months ago (2014-08-13 22:24:44 UTC) #1
jiayl
tommi@, Could you take a look?
6 years, 3 months ago (2014-09-04 23:19:49 UTC) #3
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/468393003/diff/1/content/renderer/media/peer_connection_tracker.cc File content/renderer/media/peer_connection_tracker.cc (right): https://codereview.chromium.org/468393003/diff/1/content/renderer/media/peer_connection_tracker.cc#newcode403 content/renderer/media/peer_connection_tracker.cc:403: (source == SOURCE_LOCAL) ? "onIceCandidate" can we add ...
6 years, 3 months ago (2014-09-05 07:25:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/468393003/20001
6 years, 3 months ago (2014-09-05 15:41:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/44278)
6 years, 3 months ago (2014-09-05 16:34:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/468393003/20001
6 years, 3 months ago (2014-09-06 00:00:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e5f146a62752fb11e36f7c58bf7f4815b7c19407
6 years, 3 months ago (2014-09-06 00:49:12 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d972ceb0c410b92dccc5cbf3f8118b0ac6ec3c6
Cr-Commit-Position: refs/heads/master@{#293598}

Powered by Google App Engine
This is Rietveld 408576698