Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: content/renderer/media/peer_connection_tracker.cc

Issue 468393003: Add the addIceCandidate failure case to webrtc-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/peer_connection_tracker.cc
diff --git a/content/renderer/media/peer_connection_tracker.cc b/content/renderer/media/peer_connection_tracker.cc
index 5aac78c3fd50bceb41dfbdc590b656b7862295d2..c4f10e5e88434578a57b989c5ddc17d8e48b7f73 100644
--- a/content/renderer/media/peer_connection_tracker.cc
+++ b/content/renderer/media/peer_connection_tracker.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "content/renderer/media/peer_connection_tracker.h"
+#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "content/common/media/peer_connection_tracker_messages.h"
#include "content/renderer/media/rtc_media_constraints.h"
@@ -390,12 +391,22 @@ void PeerConnectionTracker::TrackUpdateIce(
void PeerConnectionTracker::TrackAddIceCandidate(
RTCPeerConnectionHandler* pc_handler,
const blink::WebRTCICECandidate& candidate,
- Source source) {
- string value = "mid: " + base::UTF16ToUTF8(candidate.sdpMid()) + ", " +
- "candidate: " + base::UTF16ToUTF8(candidate.candidate());
- SendPeerConnectionUpdate(
- pc_handler,
- source == SOURCE_LOCAL ? "onIceCandidate" : "addIceCandidate", value);
+ Source source,
+ bool succeeded) {
+ string value =
+ "sdpMid: " + base::UTF16ToUTF8(candidate.sdpMid()) + ", " +
+ "sdpMLineIndex: " + base::IntToString(candidate.sdpMLineIndex()) + ", " +
+ "candidate: " + base::UTF16ToUTF8(candidate.candidate());
+
+ // OnIceCandidate always succeeds as it's a callback from the browser.
+ DCHECK(source != SOURCE_LOCAL || succeeded);
+
+ string event =
+ (source == SOURCE_LOCAL) ? "onIceCandidate"
+ : (succeeded ? "addIceCandidate"
+ : "addIceCandidateFailed");
+
+ SendPeerConnectionUpdate(pc_handler, event, value);
}
void PeerConnectionTracker::TrackAddStream(
« no previous file with comments | « content/renderer/media/peer_connection_tracker.h ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698