Fixing HttpPost deletion crash

Fixing HttpPost deletion crash

BUG=403284
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289450

[rkc, 2014-08-13 15:41:51]

https://codereview.chromium.org/468213002/diff/1/components/copresence/rpc/rp...
File components/copresence/rpc/rpc_handler.cc (right):

https://codereview.chromium.org/468213002/diff/1/components/copresence/rpc/rp...
components/copresence/rpc/rpc_handler.cc:322: DCHECK(elements_erased);
This will probably throw an unused variable compile error on release builds.

[Charlie, 2014-08-13 15:48:27]

https://codereview.chromium.org/468213002/diff/1/components/copresence/rpc/rp...
File components/copresence/rpc/rpc_handler.cc (right):

https://codereview.chromium.org/468213002/diff/1/components/copresence/rpc/rp...
components/copresence/rpc/rpc_handler.cc:322: DCHECK(elements_erased);
On 2014/08/13 15:41:51, Rahul Chaturvedi wrote:
> This will probably throw an unused variable compile error on release builds.

Nope, I've used this pattern before. There's even a comment about this when
DCHECK is defined:

https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&l=616

[rkc, 2014-08-13 15:56:23]

lgtm

[xiyuan, 2014-08-13 15:57:56]

lgtm

[Charlie, 2014-08-13 16:13:43]

The CQ bit was checked by ckehoe@chromium.org

[commit-bot: I haz the power, 2014-08-13 16:14:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckehoe@chromium.org/468213002/1

[commit-bot: I haz the power, 2014-08-13 22:16:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-14 03:22:14]

Committed patchset #1 (1) as 289450