Fixing HttpPost deletion crash

components/copresence/rpc/rpc_handler.cc

Index: components/copresence/rpc/rpc_handler.cc
diff --git a/components/copresence/rpc/rpc_handler.cc b/components/copresence/rpc/rpc_handler.cc
index 7d89e9d310d0edbd608cffab68356d3093bafda1..f9a409716bef31be079ac9b93b2a7a258791b909 100644
--- a/components/copresence/rpc/rpc_handler.cc
+++ b/components/copresence/rpc/rpc_handler.cc
@@ -318,7 +318,8 @@ void RpcHandler::RegisterResponseHandler(
     int http_status_code,
     const std::string& response_data) {
   if (completed_post) {
-    DCHECK(pending_posts_.erase(completed_post));
+    int elements_erased = pending_posts_.erase(completed_post);
+    DCHECK(elements_erased);

[rkc, 2014/08/13 15:41:51]

This will probably throw an unused variable compile error on release builds.

[Charlie, 2014/08/13 15:48:27]

Nope, I've used this pattern before. There's even a comment about this when
DCHECK is defined:

https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&l=616

     delete completed_post;
   }
 
@@ -347,7 +348,8 @@ void RpcHandler::ReportResponseHandler(const StatusCallback& status_callback,
                                        int http_status_code,
                                        const std::string& response_data) {
   if (completed_post) {
-    DCHECK(pending_posts_.erase(completed_post));
+    int elements_erased = pending_posts_.erase(completed_post);
+    DCHECK(elements_erased);
     delete completed_post;
   }