Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Issue 468193005: Remove SetAllowOverlappingView from RWHVMac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_ca_flag
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
index 6433c73d3a30a45db18c6d55fdc46697d7dfee9d..64133de530020ce3b829e0afa21aa9c99f897a21 100644
--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
@@ -451,7 +451,6 @@ const float kRightEdgeOffset = 25;
// If the find bar is not visible, make it actually hidden, so it'll no longer
// respond to key events.
[[self view] setHidden:![self isFindBarVisible]];
- [[self browserWindowController] onFindBarVisibilityChanged];
}
- (gfx::Point)findBarWindowPosition {
@@ -507,7 +506,6 @@ const float kRightEdgeOffset = 25;
if (!animate) {
[findBarView_ setFrame:endFrame];
[[self view] setHidden:![self isFindBarVisible]];
- [[self browserWindowController] onFindBarVisibilityChanged];
showHideAnimation_.reset(nil);
return;
}
@@ -515,13 +513,10 @@ const float kRightEdgeOffset = 25;
// If animating, ensure that the find bar is not hidden. Hidden status will be
// updated at the end of the animation.
[[self view] setHidden:NO];
- //[[self browserWindowController] onFindBarVisibilityChanged];
// Reset the frame to what was saved above.
[findBarView_ setFrame:startFrame];
- [[self browserWindowController] onFindBarVisibilityChanged];
-
showHideAnimation_.reset([self createAnimationForView:findBarView_
toFrame:endFrame
duration:duration]);
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/history_overlay_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698