chrome/browser/ui/cocoa/history_overlay_controller.mm - Issue 468193005: Remove SetAllowOverlappingView from RWHVMac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_overlay_controller.mm

Issue 468193005: Remove SetAllowOverlappingView from RWHVMac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_ca_flag

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/history_overlay_controller.mm

diff --git a/chrome/browser/ui/cocoa/history_overlay_controller.mm b/chrome/browser/ui/cocoa/history_overlay_controller.mm

index cdfb1962fac592e805d0cf41e60b25a576c9ab53..88237a3c6f771d1cc37f5bb940f9d954df5a9270 100644

--- a/chrome/browser/ui/cocoa/history_overlay_controller.mm

+++ b/chrome/browser/ui/cocoa/history_overlay_controller.mm

@@ -136,8 +136,6 @@ const CGFloat kShieldHeightCompletionAdjust = 10;

parent_.reset([view retain]);

[self setProgress:0 finished:NO]; // Set initial view position.

[parent_ addSubview:self.view];

- [[BrowserWindowController

- browserWindowControllerForView:[self view]] onOverlappedViewShown];

}

- (void)dismiss {

@@ -160,8 +158,6 @@ const CGFloat kShieldHeightCompletionAdjust = 10;

}

- (void)animationDidStop:(CAAnimation*)theAnimation finished:(BOOL)finished {

- [[BrowserWindowController

- browserWindowControllerForView:[self view]] onOverlappedViewHidden];

[self.view removeFromSuperview];

// Destroy the CAAnimation and its strong reference to its delegate (this

// class).