Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 468193005: Remove SetAllowOverlappingView from RWHVMac (Closed)

Created:
6 years, 4 months ago by ccameron
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_ca_flag
Project:
chromium
Visibility:
Public.

Description

Remove SetAllowOverlappingView from RWHVMac Then pull on the thread until everything that called it goes away. This is not needed now that CoreAnimation is the only way to draw content on Mac. BUG=245900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -190 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_view.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 3 chunks +0 lines, -17 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
ccameron
I think this gets all of the pieces.
6 years, 4 months ago (2014-08-15 18:15:07 UTC) #1
Avi (use Gerrit)
lgtm
6 years, 4 months ago (2014-08-15 18:30:23 UTC) #2
Avi (use Gerrit)
Thanks!
6 years, 4 months ago (2014-08-15 18:30:37 UTC) #3
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-15 18:49:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/468193005/1
6 years, 4 months ago (2014-08-15 18:52:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 20:56:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 21:18:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6172)
6 years, 4 months ago (2014-08-15 21:18:13 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-16 22:24:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/468193005/1
6 years, 4 months ago (2014-08-16 22:24:46 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 23:17:19 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-17 00:17:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6466)
6 years, 4 months ago (2014-08-17 00:17:09 UTC) #13
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-17 00:18:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/468193005/1
6 years, 4 months ago (2014-08-17 00:19:06 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 01:34:36 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (1) as 290166

Powered by Google App Engine
This is Rietveld 408576698