Issue 468163002: Use LookupIterator in SetAccessor / DefineAccessor and remove "search_hidden_prototypes" from Looku…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468163002: Use LookupIterator in SetAccessor / DefineAccessor and remove "search_hidden_prototypes" from Looku… (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Use LookupIterator in SetAccessor / DefineAccessor and remove "search_hidden_prototypes" from LookupOwn BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23169

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -25 lines)			Patch
M	src/lookup.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/objects.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects.cc	View	6 chunks	+15 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/468163002/diff/1/src/lookup.h File src/lookup.h (right): https://codereview.chromium.org/468163002/diff/1/src/lookup.h#newcode146 src/lookup.h:146: bool IsReadOnly() const { return property_details().IsReadOnly(); } Yeah, ...

6 years, 4 months ago (2014-08-18 15:00:19 UTC) #2

Toon Verwaest

6 years, 4 months ago (2014-08-18 15:08:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23169 (tree was closed).

Expand Messages | Collapse Messages