Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 468083003: Cleanup namespace usage in Source/web/Web[A-H]*.cpp (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, tzik, dcheng, apavlov+blink_chromium.org, aandrey+blink_chromium.org, lushnikov+blink_chromium.org, caseq+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, nhiroki, devtools-reviews_chromium.org, loislo+blink_chromium.org, philipj_slow, timvolodine, eustas+blink_chromium.org, paulirish+reviews_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, vsevik+blink_chromium.org, mvanouwerkerk+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in Source/web/Web[A-H]*.cpp - Removes unnecessary blink:: prefixes. - Removes *using namespace* usage. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180445

Patch Set 1 #

Patch Set 2 : Fixing win_blink trybot error #

Patch Set 3 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -172 lines) Patch
M Source/web/WebAXObject.cpp View 13 chunks +15 lines, -17 lines 0 comments Download
M Source/web/WebArrayBufferConverter.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebArrayBufferView.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebBindings.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M Source/web/WebBlob.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/WebCache.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M Source/web/WebCachedURLRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebColorName.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebColorSuggestion.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebCryptoNormalize.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/web/WebCustomElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMActivityLogger.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMCustomEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMError.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/WebDOMEvent.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/web/WebDOMFileSystem.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/web/WebDOMMediaStreamTrack.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebDOMMessageEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMMouseEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMProgressEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMResourceProgressEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDataSourceImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDatabase.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDateTimeSuggestion.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 10 chunks +12 lines, -14 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebDocument.cpp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebDocumentType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDragData.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/web/WebElement.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/web/WebElementCollection.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/web/WebFontDescription.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebFontImpl.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebFormControlElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebFormElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebFrame.cpp View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M Source/web/WebGeolocationController.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebGeolocationError.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebGeolocationPermissionRequest.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebGeolocationPermissionRequestManager.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/web/WebGeolocationPosition.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebGlyphCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebHeap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebHistoryItem.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebHitTestResult.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-18 05:58:15 UTC) #1
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-18 06:17:33 UTC) #2
tkent
lgtm
6 years, 4 months ago (2014-08-18 06:17:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/468083003/20001
6 years, 4 months ago (2014-08-18 06:18:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 06:18:57 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/web/WebFrame.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-18 06:18:58 UTC) #6
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 4 months ago (2014-08-18 09:13:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/468083003/40001
6 years, 4 months ago (2014-08-18 09:14:34 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 10:19:24 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 10:58:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (40001) as 180445

Powered by Google App Engine
This is Rietveld 408576698