Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 468023002: Add the condition for enabling c++11 test. (Closed)

Created:
6 years, 4 months ago by chunyang.dai
Modified:
6 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Add the condition for enabling c++11 test. The range-based for loops is supported since GCC 4.6. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/cctest/test-utils.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
chunyang.dai
hello, Sven & Michael. I found that the range-based for loops is supported since GCC ...
6 years, 4 months ago (2014-08-13 03:35:15 UTC) #1
Benedikt Meurer
On 2014/08/13 at 03:35:15, chunyang.dai wrote: > hello, > Sven & Michael. > I found ...
6 years, 4 months ago (2014-08-13 04:05:09 UTC) #2
chunyang.dai
On 2014/08/13 04:05:09, Benedikt Meurer wrote: > On 2014/08/13 at 03:35:15, chunyang.dai wrote: > > ...
6 years, 4 months ago (2014-08-13 05:57:37 UTC) #3
Sven Panne
6 years, 3 months ago (2014-08-25 11:14:28 UTC) #4
Message was sent while issue was closed.
On 2014/08/13 05:57:37, chunyang.dai wrote:
> I see. we will update our system to use GCC 4.6 or higher. 

Just FYI: The minimum requirement for Chrome is GCC >=4.8 or clang (see
chromium-dev mailing list), so it wouldn't hurt to update to that. :-)

Powered by Google App Engine
This is Rietveld 408576698