Improve reporting of subprocess crashes....

chrome/browser/renderer_host/browser_render_process_host.cc

Index: chrome/browser/renderer_host/browser_render_process_host.cc
===================================================================
--- chrome/browser/renderer_host/browser_render_process_host.cc	(revision 33701)
+++ chrome/browser/renderer_host/browser_render_process_host.cc	(working copy)
@@ -812,10 +812,16 @@
   bool did_crash =
       child_process_.get() ? child_process_->DidProcessCrash() : false;
 
+  if (did_crash) {
+    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashes",
+                             extension_process_ ? 2 : 1);

[jar (doing other things), 2009/12/18 16:28:14]

I assume you're using 2 an 1 as specific bucket types for counters.  I't might
be nice to use an enum, with a good name, and not just have raw constants
appearing here.

[asargent_no_longer_on_chrome, 2010/01/05 01:01:19]

That's a good suggestion. I'll add this to to my follow-up CL. 

+  }
+
+  RendererClosedDetails details(did_crash, extension_process_);
   NotificationService::current()->Notify(
       NotificationType::RENDERER_PROCESS_CLOSED,
       Source<RenderProcessHost>(this),
-      Details<bool>(&did_crash));
+      Details<RendererClosedDetails>(&details));
 
   WebCacheManager::GetInstance()->Remove(id());
   child_process_.reset();