Improve reporting of subprocess crashes....

chrome/browser/renderer_host/browser_render_process_host.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "chrome/browser/renderer_host/browser_render_process_host.h"
 
 #include <algorithm>
@@ skipping 794 matching lines @@
   // The OnChannelError notification can fire multiple times due to nested sync
   // calls to a renderer. If we don't have a valid channel here it means we
   // already handled the error.
   if (!channel_.get())
     return;
 
   // NULL in single process mode or if fast termination happened.
   bool did_crash =
       child_process_.get() ? child_process_->DidProcessCrash() : false;
 
+  if (did_crash) {
+    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashes",
+                             extension_process_ ? 2 : 1);

[jar (doing other things), 2009/12/18 16:28:14]

I assume you're using 2 an 1 as specific bucket types for counters.  I't might
be nice to use an enum, with a good name, and not just have raw constants
appearing here.

[asargent_no_longer_on_chrome, 2010/01/05 01:01:19]

That's a good suggestion. I'll add this to to my follow-up CL. 

+  }
+
+  RendererClosedDetails details(did_crash, extension_process_);
   NotificationService::current()->Notify(
       NotificationType::RENDERER_PROCESS_CLOSED,
       Source<RenderProcessHost>(this),
-      Details<bool>(&did_crash));
+      Details<RendererClosedDetails>(&details));
 
   WebCacheManager::GetInstance()->Remove(id());
   child_process_.reset();
   channel_.reset();
 
   IDMap<IPC::Channel::Listener>::iterator iter(&listeners_);
   while (!iter.IsAtEnd()) {
     iter.GetCurrentValue()->OnMessageReceived(
         ViewHostMsg_RenderViewGone(iter.GetCurrentKey()));
     iter.Advance();
@@ skipping 167 matching lines @@
         IPC::PlatformFileForTransit(),
         std::vector<std::string>(),
         std::string(),
         false));
   }
 }
 
 void BrowserRenderProcessHost::EnableAutoSpellCorrect(bool enable) {
   Send(new ViewMsg_SpellChecker_EnableAutoSpellCorrect(enable));
 }