Issue 467923002: Revert 288954 "[Sync] Don't synchronously stop datatypes that en..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467923002: Revert 288954 "[Sync] Don't synchronously stop datatypes that en..." (Closed)

Created:
6 years, 4 months ago by oshima

Modified:
6 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 288954 "[Sync] Don't synchronously stop datatypes that en..." Reason for revert: see crbug.com/403098 > [Sync] Don't synchronously stop datatypes that encounter errors > > The datatype logic may be operating unders assumptions that break when > the type is stopped from under it, possibly triggering crashes. > > BUG=402595, 403098 > > Review URL: https://codereview.chromium.org/462863002 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289111

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
	M	trunk/src/components/sync_driver/ui_data_type_controller.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

oshima

6 years, 4 months ago (2014-08-12 23:26:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r289111 (tree was closed).