Issue 462863002: [Sync] Don't synchronously stop datatypes that encounter errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 462863002: [Sync] Don't synchronously stop datatypes that encounter errors (Closed)

Created:
6 years, 4 months ago by Nicolas Zea

Modified:
6 years, 4 months ago

Reviewers:
haitaol1

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Sync] Don't synchronously stop datatypes that encounter errors The datatype logic may be operating unders assumptions that break when the type is stopped from under it, possibly triggering crashes. BUG=402595 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288954

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	chrome/browser/sync/glue/frontend_data_type_controller.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
	M	components/sync_driver/ui_data_type_controller.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/462863002/1

6 years, 4 months ago (2014-08-12 00:06:45 UTC) #4

Message was sent while issue was closed.

Change committed as 288954

Expand Messages | Collapse Messages