Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: ui/compositor/compositor_observer.cc

Issue 467703003: Update ui::CompositorObserver instrumentation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/compositor/compositor.cc ('K') | « ui/compositor/compositor_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/compositor_observer.cc
diff --git a/ui/compositor/compositor_observer.cc b/ui/compositor/compositor_observer.cc
index 209cd5220b38b46c6c206447e39c75795379554f..5c8cf1a7948def9a5a2732b6b7b10bab25fa421d 100644
--- a/ui/compositor/compositor_observer.cc
+++ b/ui/compositor/compositor_observer.cc
@@ -8,19 +8,17 @@
namespace ui {
-#if defined(OS_MACOSX)
-// Debugging instrumentation for crbug.com/401630.
-// TODO(ccameron): remove this.
+#if DCHECK_IS_ON
CompositorObserver::CompositorObserver() : observing_count_(0) {}
#else
CompositorObserver::CompositorObserver() {}
#endif
CompositorObserver::~CompositorObserver() {
+ // TODO(ccameron): Make this check not fire on non-Mac platforms.
+ // http://crbug.com/403011
#if defined(OS_MACOSX)
danakj 2014/08/12 20:57:54 Did you wanna remove this?
ccameron 2014/08/12 21:04:24 Nah, I wanted to keep the DCHECK for Mac, and even
- // Debugging instrumentation for crbug.com/401630.
- // TODO(ccameron): remove this.
- CHECK_EQ(observing_count_, 0);
+ DCHECK_EQ(observing_count_, 0);
#endif
}
« ui/compositor/compositor.cc ('K') | « ui/compositor/compositor_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698