Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: ui/compositor/compositor_observer.cc

Issue 467703003: Update ui::CompositorObserver instrumentation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/compositor/compositor_observer.h" 5 #include "ui/compositor/compositor_observer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace ui { 9 namespace ui {
10 10
11 #if defined(OS_MACOSX) 11 #if DCHECK_IS_ON
12 // Debugging instrumentation for crbug.com/401630.
13 // TODO(ccameron): remove this.
14 CompositorObserver::CompositorObserver() : observing_count_(0) {} 12 CompositorObserver::CompositorObserver() : observing_count_(0) {}
15 #else 13 #else
16 CompositorObserver::CompositorObserver() {} 14 CompositorObserver::CompositorObserver() {}
17 #endif 15 #endif
18 16
19 CompositorObserver::~CompositorObserver() { 17 CompositorObserver::~CompositorObserver() {
18 // TODO(ccameron): Make this check not fire on non-Mac platforms.
19 // http://crbug.com/403011
20 #if defined(OS_MACOSX) 20 #if defined(OS_MACOSX)
danakj 2014/08/12 20:57:54 Did you wanna remove this?
ccameron 2014/08/12 21:04:24 Nah, I wanted to keep the DCHECK for Mac, and even
21 // Debugging instrumentation for crbug.com/401630. 21 DCHECK_EQ(observing_count_, 0);
22 // TODO(ccameron): remove this.
23 CHECK_EQ(observing_count_, 0);
24 #endif 22 #endif
25 } 23 }
26 24
27 } 25 }
28 26
OLDNEW
« ui/compositor/compositor.cc ('K') | « ui/compositor/compositor_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698