Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ui/compositor/compositor.cc

Issue 467703003: Update ui::CompositorObserver instrumentation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/compositor/compositor_observer.h » ('j') | ui/compositor/compositor_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/compositor.cc
diff --git a/ui/compositor/compositor.cc b/ui/compositor/compositor.cc
index 14b5366b0b536d2a87ef39228c56b1a75def16e1..a33768cbec981185cd3f4849d1a1b68ba2121e02 100644
--- a/ui/compositor/compositor.cc
+++ b/ui/compositor/compositor.cc
@@ -278,9 +278,7 @@ scoped_refptr<CompositorVSyncManager> Compositor::vsync_manager() const {
}
void Compositor::AddObserver(CompositorObserver* observer) {
-#if defined(OS_MACOSX)
- // Debugging instrumentation for crbug.com/401630.
- // TODO(ccameron): remove this.
+#if DCHECK_IS_ON
CHECK(observer);
danakj 2014/08/12 20:57:54 DCHECK?
ccameron 2014/08/12 21:04:24 Done.
if (!observer_list_.HasObserver(observer))
observer->observing_count_ += 1;
@@ -290,9 +288,7 @@ void Compositor::AddObserver(CompositorObserver* observer) {
}
void Compositor::RemoveObserver(CompositorObserver* observer) {
-#if defined(OS_MACOSX)
- // Debugging instrumentation for crbug.com/401630.
- // TODO(ccameron): remove this.
+#if DCHECK_IS_ON
if (observer_list_.HasObserver(observer))
observer->observing_count_ -= 1;
#endif
« no previous file with comments | « no previous file | ui/compositor/compositor_observer.h » ('j') | ui/compositor/compositor_observer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698