AudioNodeOutput::disconnectAll() should be called in AudioNode::dispose()

AudioNodeOutput::disconnectAll() should be called in AudioNode::dispose()

Currently, in oilpan builds, AudioNodeOutput::disconnectAll() is called in AudioNode::dispose().
In non-oilpan builds, AudioNodeOutput::disconnectAll() is called in AudioNode::finishDeref().
We don't want to have different call paths between oilpan builds and non-oilpan builds.

Given that AudioNodeOutput::disconnectAll() should be called when the AudioNode is destructed
(but before the associated AudioContext is gone), AudioNodeOutput::disconnectAll() should always
be called in AudioNode::dispose().

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180277

[haraken, 2014-08-12 13:28:23]

PTAL

[tkent, 2014-08-14 02:39:31]

On 2014/08/12 13:28:23, haraken wrote:
> PTAL

Without https://codereview.chromium.org/466763002/, this CL will make a behavior
change.

[tkent, 2014-08-14 05:03:46]

> Without https://codereview.chromium.org/466763002/, this CL will make a
behavior
> change.

It was landed.  lgtm

[haraken, 2014-08-14 05:04:24]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-14 05:05:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/467683002/1

[commit-bot: I haz the power, 2014-08-14 05:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-14 05:06:00]

Failed to apply patch for Source/modules/webaudio/AudioNode.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/webaudio/AudioNode.cpp
  Hunk #1 FAILED at 110.
  Hunk #2 succeeded at 608 (offset -3 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/modules/webaudio/AudioNode.cpp.rej

Patch:       Source/modules/webaudio/AudioNode.cpp
Index: Source/modules/webaudio/AudioNode.cpp
diff --git a/Source/modules/webaudio/AudioNode.cpp
b/Source/modules/webaudio/AudioNode.cpp
index
f325bee4b7fe0be99a585a1d78a51af7652f371f..86beaf02db3ffa133ec028f325db2548c21bdd4d
100644
--- a/Source/modules/webaudio/AudioNode.cpp
+++ b/Source/modules/webaudio/AudioNode.cpp
@@ -110,9 +110,9 @@ void AudioNode::dispose()
     ASSERT(context()->isGraphOwner());
 #if ENABLE(OILPAN)
     context()->removeAutomaticPullNode(this);
+#endif
     for (unsigned i = 0; i < m_outputs.size(); ++i)
         output(i)->disconnectAll();
-#endif
     context()->unmarkDirtyNode(*this);
 #if ENABLE(ASSERT)
     m_didCallDispose = true;
@@ -611,10 +611,6 @@ void AudioNode::finishDeref()
 #endif
 
     if (!m_normalRefCount && !m_isMarkedForDeletion) {
-        // All references are gone - we need to go away.
-        for (unsigned i = 0; i < m_outputs.size(); ++i)
-            output(i)->disconnectAll(); // This will deref() nodes we're
connected to.
-
         // Mark for deletion at end of each render quantum or when context
shuts
         // down.
         context()->markForDeletion(this);

[haraken, 2014-08-14 05:10:28]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-14 05:11:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/467683002/20001

[commit-bot: I haz the power, 2014-08-14 10:55:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[commit-bot: I haz the power, 2014-08-14 14:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-14 14:08:26]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[haraken, 2014-08-14 14:24:42]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-14 14:26:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/467683002/20001

[commit-bot: I haz the power, 2014-08-14 16:07:42]

Committed patchset #2 (20001) as 180277