Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: Source/modules/webaudio/AudioNode.cpp

Issue 467683002: AudioNodeOutput::disconnectAll() should be called in AudioNode::dispose() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioNode.cpp
diff --git a/Source/modules/webaudio/AudioNode.cpp b/Source/modules/webaudio/AudioNode.cpp
index 4518d8f17c4be03d6ca9f9e73921aa8cff63920f..06169e3aa09ffe4cc971e8d8289717d9cc33baa3 100644
--- a/Source/modules/webaudio/AudioNode.cpp
+++ b/Source/modules/webaudio/AudioNode.cpp
@@ -110,10 +110,8 @@ void AudioNode::dispose()
ASSERT(context()->isGraphOwner());
context()->removeAutomaticPullNode(this);
-#if ENABLE(OILPAN)
for (unsigned i = 0; i < m_outputs.size(); ++i)
output(i)->disconnectAll();
-#endif
context()->unmarkDirtyNode(*this);
#if ENABLE(ASSERT)
m_didCallDispose = true;
@@ -608,10 +606,6 @@ void AudioNode::finishDeref()
#endif
if (!m_normalRefCount && !m_isMarkedForDeletion) {
- // All references are gone - we need to go away.
- for (unsigned i = 0; i < m_outputs.size(); ++i)
- output(i)->disconnectAll(); // This will deref() nodes we're connected to.
-
// Mark for deletion at end of each render quantum or when context shuts
// down.
context()->markForDeletion(this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698