Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 467653002: Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tzik, tburkard+watch_chromium.org, aandrey+blink_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, jam, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, michaeln, jsbell+serviceworker_chromium.org, nhiroki, gavinp+prer_chromium.org, paulirish+reviews_chromium.org, alecflett+watch_chromium.org, davidben+watch_chromium.org, tfarina, serviceworker-reviews, yurys, dominich+watch_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (https://codereview.chromium.org/449043002/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=402835 Original issue's description: > [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManager. > > Previously, client used methods on DevToolsManager passing |this| to most of them. > Instead, it should hold a scoped_refptr to inspected DevToolsAgentHost and talk > to it directly. This creates a single clean entry point for the client, and allows > in the future to handle browser-wide protocol messages and debug multiple hosts at once. > > BUG=401073 > TBR=kalman@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288452 TBR=jam@chromium.org,kalman@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=401073 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+700 lines, -468 lines) Patch
M apps/app_window_registry.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 7 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 6 chunks +18 lines, -41 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 8 chunks +23 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 10 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller_browsertest.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 1 chunk +21 lines, -15 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 4 chunks +8 lines, -101 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 5 chunks +48 lines, -52 lines 0 comments Download
M content/browser/devtools/devtools_manager_impl.h View 2 chunks +74 lines, -6 lines 0 comments Download
M content/browser/devtools/devtools_manager_impl.cc View 2 chunks +165 lines, -14 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 9 chunks +52 lines, -32 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_agent_host.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 9 chunks +28 lines, -24 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/devtools/ipc_devtools_agent_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/ipc_devtools_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler_browsertest.cc View 4 chunks +15 lines, -12 lines 0 comments Download
M content/browser/devtools/tethering_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/devtools_agent_host.h View 3 chunks +0 lines, -20 lines 0 comments Download
D content/public/browser/devtools_agent_host_client.h View 1 chunk +0 lines, -34 lines 0 comments Download
A content/public/browser/devtools_client_host.h View 1 chunk +45 lines, -0 lines 0 comments Download
A content/public/browser/devtools_manager.h View 1 chunk +65 lines, -0 lines 0 comments Download
M content/shell/browser/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
6 years, 4 months ago (2014-08-12 12:28:43 UTC) #1
Created Revert of [DevTools] Make DevTools clients talk directly to
DevToolsAgentHost instead of using DevToolsManage…

Powered by Google App Engine
This is Rietveld 408576698