Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller_browsertest.mm

Issue 467653002: Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_contro ller.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_contro ller.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/json/json_file_value_serializer.h" 8 #include "base/json/json_file_value_serializer.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
11 #include "chrome/browser/extensions/browser_action_test_util.h" 11 #include "chrome/browser/extensions/browser_action_test_util.h"
12 #include "chrome/browser/extensions/extension_action.h" 12 #include "chrome/browser/extensions/extension_action.h"
13 #include "chrome/browser/extensions/extension_action_manager.h" 13 #include "chrome/browser/extensions/extension_action_manager.h"
14 #include "chrome/browser/extensions/extension_browsertest.h" 14 #include "chrome/browser/extensions/extension_browsertest.h"
15 #include "chrome/browser/extensions/extension_tab_util.h" 15 #include "chrome/browser/extensions/extension_tab_util.h"
16 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 18 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
19 #include "chrome/browser/ui/cocoa/browser_window_controller.h" 19 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
20 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" 20 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
21 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" 21 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
22 #include "chrome/browser/ui/tabs/tab_strip_model.h" 22 #include "chrome/browser/ui/tabs/tab_strip_model.h"
23 #include "chrome/common/chrome_paths.h" 23 #include "chrome/common/chrome_paths.h"
24 #include "chrome/common/pref_names.h" 24 #include "chrome/common/pref_names.h"
25 #include "content/public/browser/devtools_agent_host.h" 25 #include "content/public/browser/devtools_manager.h"
26 #include "content/public/test/test_utils.h" 26 #include "content/public/test/test_utils.h"
27 #include "extensions/common/extension.h" 27 #include "extensions/common/extension.h"
28 #include "grit/generated_resources.h" 28 #include "grit/generated_resources.h"
29 #include "ui/base/l10n/l10n_util_mac.h" 29 #include "ui/base/l10n/l10n_util_mac.h"
30 30
31 using extensions::Extension; 31 using extensions::Extension;
32 32
33 namespace { 33 namespace {
34 34
35 NSMenuItem* GetInspectItem(NSMenu* menu) { 35 NSMenuItem* GetInspectItem(NSMenu* menu) {
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 namespace { 141 namespace {
142 142
143 class DevToolsAttachedObserver { 143 class DevToolsAttachedObserver {
144 public: 144 public:
145 DevToolsAttachedObserver(const base::Closure& callback) 145 DevToolsAttachedObserver(const base::Closure& callback)
146 : callback_(callback), 146 : callback_(callback),
147 devtools_callback_(base::Bind( 147 devtools_callback_(base::Bind(
148 &DevToolsAttachedObserver::OnDevToolsStateChanged, 148 &DevToolsAttachedObserver::OnDevToolsStateChanged,
149 base::Unretained(this))) { 149 base::Unretained(this))) {
150 content::DevToolsAgentHost::AddAgentStateCallback(devtools_callback_); 150 content::DevToolsManager::GetInstance()->AddAgentStateCallback(
151 devtools_callback_);
151 } 152 }
152 153
153 ~DevToolsAttachedObserver() { 154 ~DevToolsAttachedObserver() {
154 content::DevToolsAgentHost::RemoveAgentStateCallback(devtools_callback_); 155 content::DevToolsManager::GetInstance()->RemoveAgentStateCallback(
156 devtools_callback_);
155 } 157 }
156 158
157 void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached) { 159 void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached) {
158 if (attached) 160 if (attached)
159 callback_.Run(); 161 callback_.Run();
160 } 162 }
161 163
162 private: 164 private:
163 base::Closure callback_; 165 base::Closure callback_;
164 base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_; 166 base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_;
(...skipping 25 matching lines...) Expand all
190 scoped_refptr<content::MessageLoopRunner> loop_runner( 192 scoped_refptr<content::MessageLoopRunner> loop_runner(
191 new content::MessageLoopRunner); 193 new content::MessageLoopRunner);
192 DevToolsAttachedObserver observer(loop_runner->QuitClosure()); 194 DevToolsAttachedObserver observer(loop_runner->QuitClosure());
193 [NSApp sendAction:[inspectItem action] 195 [NSApp sendAction:[inspectItem action]
194 to:[inspectItem target] 196 to:[inspectItem target]
195 from:inspectItem]; 197 from:inspectItem];
196 loop_runner->Run(); 198 loop_runner->Run();
197 199
198 service->SetBoolean(prefs::kExtensionsUIDeveloperMode, original); 200 service->SetBoolean(prefs::kExtensionsUIDeveloperMode, original);
199 } 201 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698