Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 467483002: GYP roll 1959:1964 (Closed)

Created:
6 years, 4 months ago by bashi
Modified:
6 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GYP roll 1959:1964 This roll contains following change: r1960: Guard against configurations without 'xcode_settings' r1961: Pull in relevant targets when using xcode-ninja r1962: Currently I've special cased gyp* file modifications higher... r1963: Style changes for analyzer r1964: Provide a way to suppress implicit MIDL generation rules for actions TBR=scottmg@chromium.org BUG=321462 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 4 months ago (2014-08-12 04:51:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/467483002/1
6 years, 4 months ago (2014-08-12 04:53:18 UTC) #2
bashi
The CQ bit was unchecked by bashi@chromium.org
6 years, 4 months ago (2014-08-12 12:21:29 UTC) #3
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 4 months ago (2014-08-12 12:21:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/467483002/1
6 years, 4 months ago (2014-08-12 12:22:12 UTC) #5
commit-bot: I haz the power
Change committed as 288980
6 years, 4 months ago (2014-08-12 15:28:04 UTC) #6
scottmg
6 years, 4 months ago (2014-08-12 16:28:02 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698