Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 467323002: Fix call to completer for async closures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: set opt counter threshold in test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | tests/language/async_control_structures_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 9f10fe5263ae805fb5c0cd5929593977e3cbb2bb..1ece6c602ae4c9389bc50eb1e55d6df2c07f59ef 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1062,11 +1062,11 @@ void EffectGraphVisitor::VisitReturnNode(ReturnNode* node) {
LocalVariable* rcv_var = node->scope()->LookupVariable(
Symbols::AsyncCompleter(), false);
ASSERT(rcv_var != NULL && rcv_var->is_captured());
- Value* rcv_value = Bind(BuildLoadLocal(*rcv_var));
- Value* returned_value = Bind(BuildLoadExprTemp());
ZoneGrowableArray<PushArgumentInstr*>* arguments =
new(I) ZoneGrowableArray<PushArgumentInstr*>(2);
+ Value* rcv_value = Bind(BuildLoadLocal(*rcv_var));
arguments->Add(PushArgument(rcv_value));
+ Value* returned_value = Bind(BuildLoadExprTemp());
arguments->Add(PushArgument(returned_value));
InstanceCallInstr* call = new(I) InstanceCallInstr(
Scanner::kNoSourcePos,
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | tests/language/async_control_structures_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698