Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 467323002: Fix call to completer for async closures. (Closed)

Created:
6 years, 4 months ago by Michael Lippautz (Google)
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix call to completer for async closures. Addressing comments from https://codereview.chromium.org/460763002/ BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39207

Patch Set 1 #

Patch Set 2 : set opt counter threshold in test #

Total comments: 2

Patch Set 3 : added iterations to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/async_control_structures_test.dart View 1 2 2 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Lippautz (Google)
6 years, 4 months ago (2014-08-13 16:24:45 UTC) #1
Michael Lippautz (Google)
As suggested, I added the opt counter threshold to the test. I checked that the ...
6 years, 4 months ago (2014-08-13 16:39:09 UTC) #2
srdjan
lgtm https://codereview.chromium.org/467323002/diff/20001/tests/language/async_control_structures_test.dart File tests/language/async_control_structures_test.dart (right): https://codereview.chromium.org/467323002/diff/20001/tests/language/async_control_structures_test.dart#newcode70 tests/language/async_control_structures_test.dart:70: var asyncReturn; You can put this in a ...
6 years, 4 months ago (2014-08-13 16:49:33 UTC) #3
Michael Lippautz (Google)
https://codereview.chromium.org/467323002/diff/20001/tests/language/async_control_structures_test.dart File tests/language/async_control_structures_test.dart (right): https://codereview.chromium.org/467323002/diff/20001/tests/language/async_control_structures_test.dart#newcode70 tests/language/async_control_structures_test.dart:70: var asyncReturn; On 2014/08/13 16:49:33, srdjan wrote: > You ...
6 years, 4 months ago (2014-08-13 17:13:56 UTC) #4
Michael Lippautz (Google)
Committed patchset #3 manually as 39207 (presubmit successful).
6 years, 4 months ago (2014-08-13 17:14:49 UTC) #5
Florian Schneider
6 years, 4 months ago (2014-08-14 09:20:33 UTC) #6
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698