ended attribute has been deprecated. Adding usecounter to gather current usage statistics and let u…

ended attribute has been deprecated. Adding usecounter to gather current usage statistics and let users know that this attribute may be removed in the future and will be replaced with active attribute

BUG=392785
New Spec= http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream
Old Spec= http://dev.w3.org/2011/webrtc/editor/archives/20130824/getusermedia.html#mediastream

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181297

[Vinod Keshav, 2014-08-21 10:24:32]

PTAL

[Vinod Keshav, 2014-08-27 03:39:00]

On 2014/08/21 10:24:32, Vinod Keshav wrote:
> PTAL

Henrik@ ping
FYI:
https://groups.google.com/a/chromium.org/forum/#!mydiscussions/blink-dev/3BZJ...

Thanks
Vinod

[Henrik Grunell, 2014-08-27 05:57:30]

Sorry for the delay! See comments, we should only count first, since we'll
change the meaning of ended when introducing active/inactive.

https://codereview.chromium.org/467093003/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/467093003/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:792: return "The 'ended' attribute is
deprecated and may be removed. Please do not use it.";
I think the deprecation marking and message can be added when we add the
active/inactive attributes. And then have the message say that the meaning of
ended has changed and that active/inactive should be used instead.

In this CL, just add the counter without marking it as deprecated, so that we
get a view of the usage of it.

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
File Source/modules/mediastream/MediaStream.cpp (right):

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
Source/modules/mediastream/MediaStream.cpp:31: #include
"core/frame/UseCounter.h"
Remove.

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
Source/modules/mediastream/MediaStream.cpp:159:
UseCounter::countDeprecation(executionContext(), UseCounter::MediaStreamEnded);
Remove this.

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
File Source/modules/mediastream/MediaStream.idl (right):

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
Source/modules/mediastream/MediaStream.idl:49:
[DeprecateAs=MediaStreamEnded]readonly attribute boolean ended;
Mark with MeasureAs= instead.

[Vinod Keshav, 2014-08-27 06:37:11]

Updated as per your comments.

https://codereview.chromium.org/467093003/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/467093003/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:792: return "The 'ended' attribute is
deprecated and may be removed. Please do not use it.";
On 2014/08/27 05:57:30, Henrik Grunell wrote:
> I think the deprecation marking and message can be added when we add the
> active/inactive attributes. And then have the message say that the meaning of
> ended has changed and that active/inactive should be used instead.
> 
> In this CL, just add the counter without marking it as deprecated, so that we
> get a view of the usage of it.

Done.

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
File Source/modules/mediastream/MediaStream.cpp (right):

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
Source/modules/mediastream/MediaStream.cpp:31: #include
"core/frame/UseCounter.h"
On 2014/08/27 05:57:30, Henrik Grunell wrote:
> Remove.

Done.

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
Source/modules/mediastream/MediaStream.cpp:159:
UseCounter::countDeprecation(executionContext(), UseCounter::MediaStreamEnded);
On 2014/08/27 05:57:30, Henrik Grunell wrote:
> Remove this.

Done.

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
File Source/modules/mediastream/MediaStream.idl (right):

https://codereview.chromium.org/467093003/diff/1/Source/modules/mediastream/M...
Source/modules/mediastream/MediaStream.idl:49:
[DeprecateAs=MediaStreamEnded]readonly attribute boolean ended;
On 2014/08/27 05:57:30, Henrik Grunell wrote:
> Mark with MeasureAs= instead.

Done.

[Henrik Grunell, 2014-08-27 07:27:06]

LGTM with comment fixed. Thanks!

(Note that you'll need owners to review/stamp.)

https://codereview.chromium.org/467093003/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/MediaStream.idl (right):

https://codereview.chromium.org/467093003/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/MediaStream.idl:49:
[MeasureAs=MediaStreamEnded]readonly attribute boolean ended;
Add space before "readonly".

[Vinod Keshav, 2014-08-27 07:39:33]

v.keshav@samsung.com changed reviewers:
+ abarth@chromium.org

[Vinod Keshav, 2014-08-27 07:39:33]

Thank you!
Updated as per your comment

https://codereview.chromium.org/467093003/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/MediaStream.idl (right):

https://codereview.chromium.org/467093003/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/MediaStream.idl:49:
[MeasureAs=MediaStreamEnded]readonly attribute boolean ended;
On 2014/08/27 07:27:06, Henrik Grunell wrote:
> Add space before "readonly".

Done.

[Vinod Keshav, 2014-08-28 00:38:20]

tommi@, abarth@, can you please take a look.

Thanks,
Vinod

[tommi (sloooow) - chröme, 2014-09-01 12:12:00]

tommi@chromium.org changed reviewers:
- tommi@chromium.org

[tommi (sloooow) - chröme, 2014-09-01 12:12:20]

I think it's enough for Adam to take a look at this.

[Vinod Keshav, 2014-09-02 08:07:26]

On 2014/09/01 12:12:20, tommi wrote:
> I think it's enough for Adam to take a look at this.

abarth@ PTAL

[abarth-chromium, 2014-09-02 20:08:16]

The CQ bit was checked by abarth@chromium.org

[abarth-chromium, 2014-09-02 20:08:16]

lgtm

[commit-bot: I haz the power, 2014-09-02 20:09:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/v.keshav@samsung.com/467093003/40001

[commit-bot: I haz the power, 2014-09-02 20:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 20:09:17]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 488.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
2ab44fc3af269110047a0a528a76f7a244d37894..b36261c8b92901ccb69c151cf5a49220f8a3cee9
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -488,6 +488,7 @@ public:
         DevToolsConsoleProfile = 518,
         SVGStyleElementTitle = 519,
         PictureSourceSrc = 520,
+        MediaStreamEnded = 521,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         // Also, run update_use_counter_feature_enum.py in
chromium/src/tools/metrics/histograms/

[Vinod Keshav, 2014-09-03 07:41:49]

The CQ bit was checked by v.keshav@samsung.com

[commit-bot: I haz the power, 2014-09-03 07:42:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/v.keshav@samsung.com/467093003/60001

[commit-bot: I haz the power, 2014-09-03 08:48:48]

Committed patchset #4 (id:60001) as 181297