Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 467093003: ended attribute has been deprecated. Adding usecounter to gather current usage statistics and let u… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 781
782 case HTMLTableElementVspace: 782 case HTMLTableElementVspace:
783 return "The 'vspace' attribute on table is deprecated. Please use CSS in stead."; 783 return "The 'vspace' attribute on table is deprecated. Please use CSS in stead.";
784 784
785 case HTMLTableElementHspace: 785 case HTMLTableElementHspace:
786 return "The 'hspace' attribute on table is deprecated. Please use CSS in stead."; 786 return "The 'hspace' attribute on table is deprecated. Please use CSS in stead.";
787 787
788 case PictureSourceSrc: 788 case PictureSourceSrc:
789 return "<source src> with a <picture> parent is invalid and therefore ig nored. Please use <source srcset> instead."; 789 return "<source src> with a <picture> parent is invalid and therefore ig nored. Please use <source srcset> instead.";
790 790
791 case MediaStreamEnded:
792 return "The 'ended' attribute is deprecated and may be removed. Please d o not use it.";
Henrik Grunell 2014/08/27 05:57:30 I think the deprecation marking and message can be
Vinod Keshav 2014/08/27 06:37:11 Done.
793
791 // Features that aren't deprecated don't have a deprecation message. 794 // Features that aren't deprecated don't have a deprecation message.
792 default: 795 default:
793 return String(); 796 return String();
794 } 797 }
795 } 798 }
796 799
797 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 800 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
798 { 801 {
799 ASSERT(feature >= firstCSSProperty); 802 ASSERT(feature >= firstCSSProperty);
800 ASSERT(feature <= lastCSSProperty); 803 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
829 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 832 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
830 { 833 {
831 // FIXME: We may want to handle stylesheets that have multiple owners 834 // FIXME: We may want to handle stylesheets that have multiple owners
832 // http://crbug.com/242125 835 // http://crbug.com/242125
833 if (sheetContents && sheetContents->hasSingleOwnerNode()) 836 if (sheetContents && sheetContents->hasSingleOwnerNode())
834 return getFrom(sheetContents->singleOwnerDocument()); 837 return getFrom(sheetContents->singleOwnerDocument());
835 return 0; 838 return 0;
836 } 839 }
837 840
838 } // namespace blink 841 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698