Issue 467043: Revert 34040 - DevTools: make possible profiling of scripts doing heavy calcu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467043: Revert 34040 - DevTools: make possible profiling of scripts doing heavy calcu... (Closed)

Created:
11 years ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 34040 - DevTools: make possible profiling of scripts doing heavy calculations. Start / stop profiling commands are now sent using debugger protocol, effectively breaking into script execution. Getting profiler log and active modules is executed on IO thread. BUG=28689 TEST=none Review URL: http://codereview.chromium.org/460018 TBR=mnaganov@chromium.org interactive_ui_tests all failed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34041

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+275 lines, -518 lines)			Patch
M	chrome/renderer/devtools_agent.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/renderer/devtools_agent_filter.h	View	1 chunk	+1 line, -19 lines	0 comments	Download
M	chrome/renderer/devtools_agent_filter.cc	View	4 chunks	+4 lines, -41 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent.h	View	2 chunks	+20 lines, -2 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_impl.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_impl.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/debugger_agent.js	View	6 chunks	+154 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View	4 chunks	+1 line, -11 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools_host_stub.js	View	5 chunks	+50 lines, -87 lines	0 comments	Download
M	webkit/glue/devtools/js/inspector_controller_impl.js	View	3 chunks	+8 lines, -8 lines	0 comments	Download
D	webkit/glue/devtools/js/profiler_agent.js	View	1 chunk	+0 lines, -191 lines	0 comments	Download
M	webkit/glue/devtools/js/tests.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	webkit/glue/devtools/profiler_agent.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	webkit/glue/devtools/profiler_agent_impl.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	webkit/glue/devtools/profiler_agent_impl.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View	3 chunks	+0 lines, -41 lines	0 comments	Download
M	webkit/glue/webdevtoolsfrontend_impl.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/glue/webdevtoolsfrontend_impl.cc	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/webkit.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages