DevTools: make possible profiling of scripts doing heavy calculations.

DevTools: make possible profiling of scripts doing heavy calculations.

Start / stop profiling commands are now sent using debugger protocol,
effectively breaking into script execution. Getting profiler log and
active modules is executed on IO thread.

BUG=28689
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34040

[pfeldman, 2009-12-02 16:46:52]

http://codereview.chromium.org/460018/diff/1/3
File chrome/renderer/devtools_agent_filter.cc (right):

http://codereview.chromium.org/460018/diff/1/3#newcode66
chrome/renderer/devtools_agent_filter.cc:66: const int read_size =
v8::V8::GetLogLines(
no talking to v8 from renderer please. please implement static method on
WebDevToolsAgent that dispatches message on IO

http://codereview.chromium.org/460018/diff/1/5
File chrome/renderer/devtools_client.cc (right):

http://codereview.chromium.org/460018/diff/1/5#newcode126
chrome/renderer/devtools_client.cc:126: s >> position;
don't use streams please. see string_util.h

[mnaganov (inactive), 2009-12-07 10:01:37]

http://codereview.chromium.org/460018/diff/1/3
File chrome/renderer/devtools_agent_filter.cc (right):

http://codereview.chromium.org/460018/diff/1/3#newcode66
chrome/renderer/devtools_agent_filter.cc:66: const int read_size =
v8::V8::GetLogLines(
On 2009/12/02 16:46:52, pfeldman wrote:
> no talking to v8 from renderer please. please implement static method on
> WebDevToolsAgent that dispatches message on IO

Done.

http://codereview.chromium.org/460018/diff/1/5
File chrome/renderer/devtools_client.cc (right):

http://codereview.chromium.org/460018/diff/1/5#newcode126
chrome/renderer/devtools_client.cc:126: s >> position;
On 2009/12/02 16:46:52, pfeldman wrote:
> don't use streams please. see string_util.h

Done.

[mnaganov (inactive), 2009-12-07 10:05:13]

This is a corresponding change in WebKit:

diff --git a/WebKit/chromium/public/WebDevToolsAgent.h
b/WebKit/chromium/public/WebDevToolsAgent.h
index 327d445..f9decd4 100644
--- a/WebKit/chromium/public/WebDevToolsAgent.h
+++ b/WebKit/chromium/public/WebDevToolsAgent.h
@@ -72,6 +72,14 @@ public:
     // Asynchronously request debugger to pause immediately.
     WEBKIT_API static void debuggerPauseScript();
 
+    // Asynchronously processes a message from frontend, returns whether
+    // a message has been processed and a reply send.
+    WEBKIT_API static bool lightweightDispatchMessageFromFrontend(const
WebString& className,
+                                                                  const
WebString& methodName,
+                                                                  const
WebString& param1,
+                                                                  const
WebString& param2,
+                                                                  const
WebString& param3);
+
     typedef void (*MessageLoopDispatchHandler)();
 
     // Installs dispatch handle that is going to be called periodically
diff --git a/WebKit/chromium/public/WebDevToolsAgentClient.h
b/WebKit/chromium/public/WebDevToolsAgentClient.h
index d3c48c7..0633bb7 100644
--- a/WebKit/chromium/public/WebDevToolsAgentClient.h
+++ b/WebKit/chromium/public/WebDevToolsAgentClient.h
@@ -53,6 +53,12 @@ public:
     // Notifies host upon runtime feature being enabled/disabled.
     virtual void runtimeFeatureStateChanged(const WebString& feature, bool
enabled) = 0;
 
+    WEBKIT_API static void asyncSendMessageToFrontend(const WebString&
className,
+                                                      const WebString&
methodName,
+                                                      const WebString& param1,
+                                                      const WebString& param2,
+                                                      const WebString& param3);
+
 protected:
     ~WebDevToolsAgentClient() {}
 };

[pfeldman, 2009-12-07 10:39:44]

LGTM with comments.

http://codereview.chromium.org/460018/diff/4001/4003
File chrome/renderer/devtools_agent_filter.cc (right):

http://codereview.chromium.org/460018/diff/4001/4003#newcode70
chrome/renderer/devtools_agent_filter.cc:70: message_handled_ =
WebDevToolsAgent::lightweightDispatchMessageFromFrontend(
dispatchOnIOThread

http://codereview.chromium.org/460018/diff/4001/4004
File chrome/renderer/devtools_agent_filter.h (right):

http://codereview.chromium.org/460018/diff/4001/4004#newcode53
chrome/renderer/devtools_agent_filter.h:53: static int current_routing_id_;
You could do something like RenderThread::current()->devtools_filter() instead
of making members static.

http://codereview.chromium.org/460018/diff/4001/4015
File webkit/glue/devtools/profiler_agent_impl.h (right):

http://codereview.chromium.org/460018/diff/4001/4015#newcode14
webkit/glue/devtools/profiler_agent_impl.h:14: class ProfilerAgentImpl : public
ProfilerAgent {
Please mention that these methods can be called on IO thread.

http://codereview.chromium.org/460018/diff/4001/4015#newcode26
webkit/glue/devtools/profiler_agent_impl.h:26: ProfilerAgentDelegate* delegate_;
DISALLOW?

http://codereview.chromium.org/460018/diff/4001/4016
File webkit/glue/webdevtoolsagent_impl.cc (right):

http://codereview.chromium.org/460018/diff/4001/4016#newcode608
webkit/glue/webdevtoolsagent_impl.cc:608: class IORPCDelegate : public
DevToolsRpc::Delegate {
Chromium style: 
1) Declare on top
2) Use anonymous namespace
3) Use camel case: IoRpcDelegate
4) Disallow

[mnaganov (inactive), 2009-12-07 13:11:41]

http://codereview.chromium.org/460018/diff/4001/4003
File chrome/renderer/devtools_agent_filter.cc (right):

http://codereview.chromium.org/460018/diff/4001/4003#newcode70
chrome/renderer/devtools_agent_filter.cc:70: message_handled_ =
WebDevToolsAgent::lightweightDispatchMessageFromFrontend(
On 2009/12/07 10:39:44, pfeldman wrote:
> dispatchOnIOThread

dispatchMessageFromFrontendOnIOThread

http://codereview.chromium.org/460018/diff/4001/4004
File chrome/renderer/devtools_agent_filter.h (right):

http://codereview.chromium.org/460018/diff/4001/4004#newcode53
chrome/renderer/devtools_agent_filter.h:53: static int current_routing_id_;
On 2009/12/07 10:39:44, pfeldman wrote:
> You could do something like RenderThread::current()->devtools_filter() instead
> of making members static.

Unfortunately, current() is implemented using thread local storage, so it's only
accessible inside renderer thread.

http://codereview.chromium.org/460018/diff/4001/4015
File webkit/glue/devtools/profiler_agent_impl.h (right):

http://codereview.chromium.org/460018/diff/4001/4015#newcode14
webkit/glue/devtools/profiler_agent_impl.h:14: class ProfilerAgentImpl : public
ProfilerAgent {
On 2009/12/07 10:39:44, pfeldman wrote:
> Please mention that these methods can be called on IO thread.

Done.

http://codereview.chromium.org/460018/diff/4001/4015#newcode26
webkit/glue/devtools/profiler_agent_impl.h:26: ProfilerAgentDelegate* delegate_;
On 2009/12/07 10:39:44, pfeldman wrote:
> DISALLOW?

Done.

http://codereview.chromium.org/460018/diff/4001/4016
File webkit/glue/webdevtoolsagent_impl.cc (right):

http://codereview.chromium.org/460018/diff/4001/4016#newcode608
webkit/glue/webdevtoolsagent_impl.cc:608: class IORPCDelegate : public
DevToolsRpc::Delegate {
On 2009/12/07 10:39:44, pfeldman wrote:
> Chromium style: 
> 1) Declare on top
> 2) Use anonymous namespace
> 3) Use camel case: IoRpcDelegate
> 4) Disallow

Done.