Disabled ConnectFailure test due to flaky valgrind failures.

Disabled ConnectFailure test due to flaky valgrind failures.
BUG=29471
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33909

[willchan no longer on Chromium, 2009-12-05 01:51:18]

TBR

[not_the_right_dank, 2009-12-05 02:23:49]

That's not the way to do it.... see the valgrind doc in the chromium wiki,
you want to disable it just for valgrind.  I'll send a link when I'm back at
a computer.

On Dec 4, 2009 5:51 PM, <willchan@chromium.org> wrote:

Reviewers: Mike Belshe,

Message:
TBR

Description:
Disabled ConnectFailure test due to flaky valgrind failures.
BUG=29471

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33909

Please review this at http://codereview.chromium.org/467031

Affected files:
 M net/flip/flip_network_transaction_unittest.cc


Index: net/flip/flip_network_transaction_unittest.cc
diff --git a/net/flip/flip_network_transaction_unittest.cc
b/net/flip/flip_network_transaction_unittest.cc
index
be0172f118dd1355de4f17cb4e4394d26ffe94ac..a236194c29231074f87673276c8ecffc73102e30
100644
--- a/net/flip/flip_network_transaction_unittest.cc
+++ b/net/flip/flip_network_transaction_unittest.cc
@@ -880,7 +880,9 @@ TEST_F(FlipNetworkTransactionTest, PartialWrite) {
  EXPECT_EQ("hello!", out.response_data);
 }

-TEST_F(FlipNetworkTransactionTest, ConnectFailure) {
+// Disabled due to flaky mac (and possibly linux) valgrind errors.
+// http://crbug.com/29471
+TEST_F(FlipNetworkTransactionTest, DISABLED_ConnectFailure) {
  MockConnect connects[]  = {
    MockConnect(true, ERR_NAME_NOT_RESOLVED),
    MockConnect(false, ERR_NAME_NOT_RESOLVED),

[willchan_google.com, 2009-12-05 02:25:47]

Yeah, I know.  I was feeling lazy about getting the valgrind
suppression right.  And I was told that it failed on mac valgrind and
MIGHT be flaky on linux valgrind.  I figured, what the hell, it's a
new test, I'll let Mike figure it out later.

On Fri, Dec 4, 2009 at 6:23 PM, Dan Kegel <dank@kegel.com> wrote:
> That's not the way to do it.... see the valgrind doc in the chromium wiki,
> you want to disable it just for valgrind.  I'll send a link when I'm back at
> a computer.
>
> On Dec 4, 2009 5:51 PM, <willchan@chromium.org> wrote:
>
> Reviewers: Mike Belshe,
>
> Message:
> TBR
>
> Description:
> Disabled ConnectFailure test due to flaky valgrind failures.
> BUG=29471
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33909
>
> Please review this at http://codereview.chromium.org/467031
>
> Affected files:
>  M net/flip/flip_network_transaction_unittest.cc
>
>
> Index: net/flip/flip_network_transaction_unittest.cc
> diff --git a/net/flip/flip_network_transaction_unittest.cc
> b/net/flip/flip_network_transaction_unittest.cc
> index
>
be0172f118dd1355de4f17cb4e4394d26ffe94ac..a236194c29231074f87673276c8ecffc73102e30
> 100644
> --- a/net/flip/flip_network_transaction_unittest.cc
> +++ b/net/flip/flip_network_transaction_unittest.cc
> @@ -880,7 +880,9 @@ TEST_F(FlipNetworkTransactionTest, PartialWrite) {
>   EXPECT_EQ("hello!", out.response_data);
>  }
>
> -TEST_F(FlipNetworkTransactionTest, ConnectFailure) {
> +// Disabled due to flaky mac (and possibly linux) valgrind errors.
> +// http://crbug.com/29471
> +TEST_F(FlipNetworkTransactionTest, DISABLED_ConnectFailure) {
>   MockConnect connects[]  = {
>     MockConnect(true, ERR_NAME_NOT_RESOLVED),
>     MockConnect(false, ERR_NAME_NOT_RESOLVED),
>
>
>