Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: net/flip/flip_network_transaction_unittest.cc

Issue 467031: Disabled ConnectFailure test due to flaky valgrind failures. (Closed)
Patch Set: Add bug link. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/flip/flip_network_transaction_unittest.cc
diff --git a/net/flip/flip_network_transaction_unittest.cc b/net/flip/flip_network_transaction_unittest.cc
index be0172f118dd1355de4f17cb4e4394d26ffe94ac..a236194c29231074f87673276c8ecffc73102e30 100644
--- a/net/flip/flip_network_transaction_unittest.cc
+++ b/net/flip/flip_network_transaction_unittest.cc
@@ -880,7 +880,9 @@ TEST_F(FlipNetworkTransactionTest, PartialWrite) {
EXPECT_EQ("hello!", out.response_data);
}
-TEST_F(FlipNetworkTransactionTest, ConnectFailure) {
+// Disabled due to flaky mac (and possibly linux) valgrind errors.
+// http://crbug.com/29471
+TEST_F(FlipNetworkTransactionTest, DISABLED_ConnectFailure) {
MockConnect connects[] = {
MockConnect(true, ERR_NAME_NOT_RESOLVED),
MockConnect(false, ERR_NAME_NOT_RESOLVED),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698