DescriptionRevert of Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (patchset #1 of https://codereview.chromium.org/462083003/)
Reason for revert:
The CL turns out to be innocent. Reverting the revert
Original issue's description:
> Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/)
>
> Reason for revert:
> Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab
>
> Original issue's description:
> > site isolation: cross-site transfers should track the RenderFrameHost, not the View
> >
> > This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap.
> >
> > 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames.
> >
> > 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating.
> >
> > 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state.
> >
> > BUG=304341, 400850
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867
>
> TBR=creis@chromium.org,nick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=304341, 400850
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289049
TBR=creis@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=304341, 400850
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289082
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|